← Back to team overview

zim-wiki team mailing list archive

Re: Cleanup Attachments commented out?


On Wed, Dec 21, 2011 at 8:41 PM, N8 <nathan.king@xxxxxxxxxxx> wrote:
> I seen a very useful feature in the Zim manual called  "Cleanup
> Attachments", http://zim-wiki.org/manual/Help/Menu_Items.html, but it
> did not appear in the menu.  While poking around for some other stuff I
> came across what looked like the code for performing the Cleanup
> Attachments feature this encouraged me to poked around a bit more and I
> noticed that menubar.xml has "<menuitem action='show_clean_notebook'/>"
> commented out.  I un-commented this and have done a couple simple tests
> on the feature and find it to be working well and to be very useful.
> Is there a specific reason the Cleanup Attachments feature is commented
> out?  Are there some known issues?

Main reason is lack of testing at the time and ongoing discussion how
/ where to put this feature. Afraid it simply wasn't high enough on my
priority list to test it thoroughly enough to put it in so I commented
it out before release. But should have come back to that, so basically
me dropping the ball on that one.

Since this happened we now also have a function to trash stuff instead
of deleting permanently, which makes it a bit less critical. So if you
and/or others can confirm it works correctly and we change it to use
the trash, I'm fine with putting it in in the next feature release.



Follow ups