dolfin team mailing list archive

["Garth N. Wells" <gnw20@xxxxxxxxx>]

On 07/10/10 17:19, Johan Hake wrote:
> On Thursday October 7 2010 05:33:26 Christine Tobler wrote:
> > Question #128225 on DOLFIN changed:
> > https://answers.launchpad.net/dolfin/+question/128225
> >
> >      Status: Answered =>  Open
> >
> > Christine Tobler is still having a problem:
> > Hi Johan,
> >
> > Of course I can change the files to use C++ streams (if I manage to get
> > the development version running). This only affects the body of the
> > functions, not any of the declaration parts, doesn't it?
>
> Once you have the development version on your computer you should be able to
> do something like:
>
>    bzr log -revert -r 5089 dolfin/io/Foo
>
> on the files I mentioned below.
>
> > By the way, what was the problem with leaving in the fprintf parts? Is
> > it a compiler issue or just about standardizing the code (making it more
> > C++-y)?
>
> We have tried to standardize all our file io on using C++ streams. They are
> more safe.
>
> Again, Garth might want to fill in some details on the above.

It wasn't just streams - the files were in a bit of a mess with Matlab 
and Octave versions (a distinction that is no longer required), so a 
complete re-write was in order.

Garth

> Johan
>
> > Christine
> >
> > On 10/07/2010 03:36 AM, Johan Hake wrote:
> > > Your question #128225 on DOLFIN changed:
> > > https://answers.launchpad.net/dolfin/+question/128225
> > >
> > >       Status: Open =>   Answered
> > >
> > > Johan Hake proposed the following answer:
> > > Christine!
> > >
> > > The files needed to be upgraded to use C++ streams, and because it was
> > > not needed by core developers it was removed.
> > >
> > > They can probably be re-added if requested.
> > >
> > > If you have the development version you can revert the changes of the
> > >
> > > files:
> > >     dolfin/io/MFile.cpp
> > >     dolfin/io/MFile.h
> > >     dolfin/io/MatlabFile.cpp
> > >     dolfin/io/MatlabFile.h
> > >     dolfin/io/File.cpp
> > >     dolfin/io/File.h
> > >
> > > from revision 5090. And if you are able upgrade to use C++ streams it
> > > would be even better! You can probably have a look in PythonFile.{cpp,h}
> > > for some guidence.
> > >
> > > Garth would probably also have some oppinions.
> > >
> > > Johan
> > >
> > > On Wednesday October 6 2010 17:42:50 Christine Tobler wrote:
> > > > New question #128225 on DOLFIN:
> > > > https://answers.launchpad.net/dolfin/+question/128225
> > > >
> > > > Hi,
> > > >
> > > > The class MFile (for file export to Matlab/Octave files) seems to have
> > > > disappeared between 0.9.8 and 0.9.9. I couldn't find out why in the
> > > > ChangeLog, do you know the reason?
> > > >
> > > > Thank you,
> > > > Christine
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dolfin
> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dolfin
> More help   : https://help.launchpad.net/ListHelp