kicad-developers team mailing list archive

[Lorenzo Marcantonio <l.marcantonio@xxxxxxxxxxxx>]

On Fri, 9 Jul 2010, Brian F. G. Bidulock wrote:

> However, there are times where things cannot be achieved
> by organic growth alone.  Although pcbnew looks nice on
> the outside, the inside lacked proper design patterns and
> MCV separation.

Urk... buzzword storm ahoy :P:P seriously some MVC would be useful, but
IMHO most dp are concentrated bull* :D

On the organic growth thing I concur, I have myself a lot of 'pending'
stuff (and I'm doing a lot of cherrypicking for each patch I submit).

But since these are mostly 'features' patch, it's still feasible.

> Don't worry about the little things.  I'm am smart enough
> to hold to coding convention.

I simply can't stand kicad's coding conventions.. they just hurt the
eyes :D luckily there's uncrustify to fix before submission!

Relating to the pervasiveness of the patches, I can say there's some...
uhm... "legacy" cruft and some serious case of code duplication around.

Centralizing the user unit handling uncovered some programming gems,
like: the UI code uses INCHES and MILLIMETERS (#defined to 0 and 1) to
convert user unit to internal unit. Well, *someone* in the 3d model
setup decided to pass 2 (yes, a magic number, not even added a define)
to handle the model parameters. I'm changing that 'int' to and enum, do
your math :D (also all the if INCHES or if MILLIMETERS to be converted
to switches for proper future handling).

> I am a good tech writer too and can update documentation in
> English.  Then at some point you must of course decide whether
> to switch to the newer branch or abandon it.

Have you a 'road map' to the changes you've made? that could greatly
help in porting the changes.

--
Lorenzo Marcantonio
Logos Srl