← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Saving plot dialog settings


On Wed, Feb 9, 2011 at 5:35 PM, Wayne Stambaugh <stambaughw@xxxxxxxxxxx> wrote:
> It looks good.  It certainly is a huge improvement over the old dialog.  Aside
> from some minor alignment issues the only comment I have is what does the
> "Apply Settings" button do?  If it just copies the dialog settings to
> application variables, why not do this on close if there are any changes?  If
> it does more than that, then a more descriptive button name may be useful.

The apply settings button is a remnant from the old dialog. I does
what you thought it would do. I guess the original idea was to make it
possible to close the dialog without saving some goofy settings.
Currently the settings are "saved" when plot or apply settings is
clicked. But you're right. We probably can survive without the apply
settings button.


Follow ups