kicad-developers team mailing list archive

[Nick Østergaard <oe.nick@xxxxxxxxx>]

Hello Dick et. al.

I will now try my luck with a new patch for this. I looked some more
in the bug tracker and I was reminded, that I actually was trying to
fix this in another way.

What I have done now it is to just use an environment variable inside
the kicad-install.sh script. It exports BZR_EMAIL with some dummy
information, _if_ one has not set it.

This should be way more safe, because it does not touch the cmake build system.

2014-04-06 23:17 GMT+02:00 Dick Hollenbeck <dick@xxxxxxxxxxx>:
>
> Hello,
>
> I see that Nick proposed a patch, which saves someone about 30 seconds and costs me an
> unknown amount of time to backtrack into the patch history, and verify that it does not
> break anything, considering we are using dummy repos all over the place.
>
>
> Its not worth it to me, just set bzr whoami and have a genuine bzr installation, not a
> half ass-ed one.
>
>
> Dick
>
>
>
> On 04/06/2014 04:06 PM, Nick Østergaard wrote:
>> Hello
>>
>> I see that Dick now merged the no lp login install script - great.
>> That also solved the step 9 not completing (at least for me).
>>
>> But the script still requires that the bzr whoami is set when it tries
>> to build boost. My suggestion to fix this is attached.
>>
>> It removed the bzr whoami check in the install script, because that is
>> not needed anymore, since we now use https to dowload the sources and
>> that I patched the download_boost.cmake to use some dummy bzr whoami
>> information (sot it is always set here). This is overrides whatever
>> bzr whoami that is set in that step, but I guess that is fine, because
>> this step is not to be comitted anywhere else than locally.
>>
>> Regards
>> Nick Østergaard
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

=== modified file 'scripts/kicad-install.sh'
--- scripts/kicad-install.sh	2014-04-06 19:21:10 +0000
+++ scripts/kicad-install.sh	2014-04-09 22:09:23 +0000
@@ -125,7 +125,10 @@
     fi
 
     # ensure bzr name and email are set.  No message since bzr prints an excellent diagnostic.
-    bzr whoami || exit 2
+    bzr whoami || {
+        echo "WARNING: You have not set bzr whoami, so I will set a dummy."
+        export BZR_EMAIL="Kicad Build <nobody@foo>"
+    }
 }