In response to your previous comments, Wayne, I said:
"I can’t guarantee that I’ll be able to do anything, but I will try.
I have no Windows or Linux machines so if someone could provide me a Windows binary of the trackpad branch maybe I can beg or borrow a box to at least observe the behavior. I won’t have a Windows development environment so I’ll just have to hope I can see something by inspection."
I got no response.
I haven't observed this behavior so it makes it a bit difficult to fix. There’s nothing in the code that should be pointing device specific so could be down to anything. I will still take a look if I can get something to look at. Are there any OS X developers out there with a windows development setup?
It’s not impossible or even difficult to make it conditional but it would be ugly; the patch was written with the idea of being merged as some point. It isn’t the gestures, per se. The main change is that since the panning gesture presents itself as a mousewheel event, the mousewheel panning code was changed to give a better experience. There’s also the issue of the preferences.
At this point perhaps I should just change this to be conditionally compiled, as ugly as it may be. At least OS X users would get a usable pointing device. I did, by the way, test this on OS X with several alternative third-party devices, including mice of various sorts and trackballs. I never observed anything like that described.
Garth
On Apr 2, 2015, at 6:54 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
I've commented on this before. It breaks zoom and pan behavior on
windows and linux so it cannot be committed until it is fixed. I don't
have an issue with providing nightly osx builds for users to test but I
would tread carefully here. It seems that some osx users are using
alternate pointing devices with success so while you may fix one users
problem you may create a problem for another user. If you choose to
create nightly builds with this patch, please make sure you label the
build as such so users can choose accordingly.
I don't understand the difficultly in modifying the patch to either be a
build time option or a run time option. How hard would it be to use
something like wxPlatform to check if osx is the platform and a user
option to enable/disable the osx gesture support. Something like:
if( (wxPlatform::Get().GetOperatingSystemId() & wxOS_MAC)
&& enableOSXGestures )
{
perform OSX gesture specific behavior
}
else
{
perform the existing behavior
}
If speed is an issue, you can keep the wxOperatingSystemId in memory
rather than checking it every time.
On 4/2/2015 9:34 AM, Adam Wolf wrote:
I don't want to make that choice. I will leave that up to Wayne.
I will support making builds of whatever he chooses.
Adam Wolf
On Apr 2, 2015 9:31 AM, "Tomasz Wlostowski" <tomasz.wlostowski@xxxxxxx
<mailto:tomasz.wlostowski@xxxxxxx>> wrote:
On 02.04.2015 11:01, Bernhard Stegmaier wrote:
For me, this is still the reason why KiCad without Garths panning
patches is just a no-go on OSX.
Adam, Wayne,
I guess there's no problem with merging these patches to the Mac stable
release, especially since we need to build a patched wxWidgets version
anyway?
Cheers,
Tom
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
