← Back to team overview

kicad-developers team mailing list archive

Re: Eeschema config keyboard mnemonics

 

They seem to work ok on windows so it must be wxGTK that is the issue.

On 8/5/2015 6:09 PM, Chris Pavlina wrote:
> Actually it is not a problem with my patch. It may be a wx bug or a 
> kicad bug - this needs further investigation. Maybe someone is listening 
> who knows wx better?
> 
> The mnemonics are broken even without my patch. Many items do not 
> respond. After trying to get them working, I have a pile of these in my 
> terminal:
> 
> (eeschema:32117): Gtk-WARNING **: widget `wxPizza' isn't suitable for mnemonic activation
> 
> What the everliving /hell/ is a wxPizza. I can find very little 
> documentation on it, other than someone else also complaining that it is 
> interfering with his events (with no follow-up).
> 
> Anybody?
> 
> 
> On Wed, Aug 05, 2015 at 06:02:02PM -0400, Wayne Stambaugh wrote:
>> I'll hold off committing this until I see your update.
>>
>> On 8/5/2015 5:41 PM, Chris Pavlina wrote:
>>> Indeed, something strange is going on with the mnemonics. It's not 
>>> responding to the correct ones in the correct places in this dialog. 
>>> Don't commit this. I'll have a closer look tonight.
>>>
>>> On Wed, Aug 05, 2015 at 05:39:34PM -0400, Jon Neal wrote:
>>>> I really like the wording changes in the dialogs. They are much more
>>>> consistent and understandable in my opinion. I am definitely +1 on this.
>>>>
>>>> However, I think this needs a bit more work as the mnemonics aren't working
>>>> on my system. (I have alerted Chris to this on IRC, just want to make sure
>>>> this doesn't get committed accidentally).
>>>>
>>>> Other than the marked letters/mnemonics not working correctly everything
>>>> else seems to be correct.
>>>>
>>>> Jon Neal
>>>>
>>>>
>>>>
>>>> On Wed, Aug 5, 2015 at 3:05 PM, Chris Pavlina <pavlina.chris@xxxxxxxxx>
>>>> wrote:
>>>>
>>>>> Here's a patch to fix the option dialog mnemonics.
>>>>>
>>>>> - Fix conflicting mnemonics in eeschema options
>>>>> - Add mnemonics to pcbnew, modedit, libedit options
>>>>>
>>>>> While I was doing it, I also cleaned up the padding/spacing in the
>>>>> dialogs (there were a few misaligned labels), and I removed an obsolete
>>>>> dialog DIALOG_LIBEDIT_DIMENSIONS (this appears to have been merged into
>>>>> DIALOG_LIBEDIT_OPTIONS a while ago and there is no remaining codepath
>>>>> that calls it).
>>>>>
>>>>> --
>>>>> Chris
>>>>>
>>>>> On Tue, Aug 04, 2015 at 02:28:47PM -0400, Wayne Stambaugh wrote:
>>>>>> On 8/3/2015 1:02 PM, Chris Pavlina wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> The keyboard mnemonics (underlined letters) in the eeschema and libedit
>>>>>>> config boxes are a bit messy. There is at least one conflict (two items
>>>>>>> sharing L), and many items missing mnemonics.
>>>>>>>
>>>>>>> I could easily patch this, but I'd rather discuss: perhaps they should
>>>>>>> be removed? It is not usual to have mnemonics in large, complicated
>>>>>>> dialogs like this - they're not particularly useful there, and they are
>>>>>>> error-prone as the current state demonstrates. People forget to add
>>>>>>> them, or miss conflicts. Mnemonics are much more useful in dialogs that
>>>>>>> are used frequently like text edit dialogs, where a user might want,
>>>>> for
>>>>>>> example, to jump quickly to the "text size" field. With so many
>>>>> options,
>>>>>>> nobody is going to remember the mnemonics anyway (note what "mnemonic"
>>>>>>> means: it's a memory aid!), and it doesn't save any time when one has
>>>>> to
>>>>>>> squint at all the options to find the underlined letter.
>>>>>>>
>>>>>>> Of course the possibility for inconsistency goes even farther: I
>>>>> haven't
>>>>>>> even checked the localizations to see how they behave.
>>>>>>>
>>>>>>> Anybody else in favor of just removing them from these two dialogs? The
>>>>>>> pcbnew and modedit dialogs already do not use them, and most other GUI
>>>>>>> applications that I checked now also do not use them in their
>>>>>>> Preferences boxes.
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Chris
>>>>>>>
>>>>>>
>>>>>> While your logic make sense, my preference is to keep the mnemonics, fix
>>>>>> any duplicates, and add the missing ones in any offending dialogs.  I
>>>>>> realize on some complex dialogs, it can be difficult to set unique
>>>>>> mnemonics but that's pretty rare.  There are still a lot of us old
>>>>>> timers around who prefer our keyboards over reaching for the mouse
>>>>>> whenever possible.  I know it's passe and quaint but I'm not ready to
>>>>>> give it up just yet :)
>>>>>>
>>>>>> _______________________________________________
>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 



Follow ups

References