kicad-developers team mailing list archive

[Tomasz Wlostowski <tomasz.wlostowski@xxxxxxx>]

On 30.04.2017 14:47, Russell Oliver wrote:
> Hi Tom, 
> 
> sorry again, 
> Attached is a fixed patch. 

Hi Russell,

I'd like to merge it. Few more comments:
- check code indentation (you have a mix of tabs and spaces). uncrustify
tool can do that for you.
- the argument naming should follow the aArgument1, aArg2, etc. convention
- the tool is relatively complex. consider creating a new tool class for
it, the EDIT_TOOL class is already quite big.

Best,
Tom