kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

On 11/21/2017 05:06 PM, Nick Østergaard wrote:
> 2017-11-21 10:22 GMT+01:00 Nick Østergaard <oe.nick@xxxxxxxxx>:
> 
>> 2017-11-21 <20%2017%2011%2021> 9:43 GMT+01:00 Maciej Sumiński <
>> maciej.suminski@xxxxxxx>:
>>
>>> On 11/20/2017 11:16 PM, Nick Østergaard wrote:
>>>> Hello Maciej,
>>>
>>> Hi Nick,
>>>
>>>> I have some comments:
>>>>
>>>> First of all, it looks quite neat.
>>>
>>> I am glad to hear that. Thank you for the test ride!
>>>
>>>> Secondly I noticed a small thing. When I open the symbol library editor
>>> and
>>>> it open in a small window and i resize it (make it bigger). The canvas
>>>> contains some resizing artefacts, but if I zoom on step with the scroll
>>>> whell and resize the window these aretefacts are not present. I am
>>>> guessing: Maybe something needs to be initialized, or maybe it only
>>> draws
>>>> the viewable area initially, but have a bigger area cached after a zoom
>>>> action.
>>>>
>>>> Thirdly it seems strange to me that when I edit something (move a pin)
>>> and
>>>> try to close the editor it asks me to selct a library. Hmm, ok? The
>>> dialog
>>>> is named "Save Libraries", but there is no OK or cancel button. This is
>>>> stange and unexpected. This means that I can't really save or reject my
>>>> changes.
>>>
>>> Indeed these two points are unexpected. Do you use an exotic window
>>> manager? I tested the new library editor with awm (I consider it
>>> somewhat unusual wm) on Linux, xfce on Linux and Windows 7. I could not
>>> reproduce the problems on any of the mentioned configurations.
>>>
>>
>> No, normally I use i3, but this time I used a default gnome3 desktop on
>> archlinux. Dunno what the window manager is called nowadays.
>>
>> It is required to start in a floating small window to be able to see the
>> effect from point my second point.
>>
>> So you say that the "Save Libraries" dialog gives you the ability to
>> confirm or reject?  I mean I have the window managers close button but, the
>> check boxes and the select all and select none buttons. But no Save/OK or
>> Cancel button.
>>
> 
> Intial window:
> http://storage7.static.itmages.com/i/17/1121/h_1511280056_3771965_553e8fe830.png
> When resizing:
> http://storage1.static.itmages.com/i/17/1121/h_1511280096_3285438_9b4d6cf913.png
> 
> See the artifacts. They dissapear if I zoom.   This is not a regression of
> your libedit branch.

Perhaps it is related to wxWidgets version you use. I could not observe
it anywhere, including the master branch.

> Here the buttons are gone, but I think I can see some pixels of it...
> http://storage2.static.itmages.com/i/17/1121/h_1511280153_9351314_c380fb9db0.png
> If I resize the dialog the buttons apear fully. So you need to edit
> multiple libs and then try to close libedit.

Thank you for the hint, now I see it here. Working on a fix, stay tuned.

Regards,
Orson

>>
>>>> Fourthly, when I have multiple libs open, and I seach it seems to alway
>>>> unfold the last lib. I would probably have expected all libs with
>>> matches
>>>> in it being unfolded, such that I can see the entries I am searching
>>> for.
>>>
>>> Agreed, this could be improved. It should not take much time to fix, I
>>> will try to add it before merging.
>>>
>>> Regards,
>>> Orson
>>>
>>>> I tested 0431a6fc6ce128973308638c1011bc95049fb173 from your libedit
>>> branch
>>>> on archlinux.
>>>>
>>>> Application: kicad
>>>> Version: (2017-11-20 revision 0431a6fc6)-HEAD, debug build
>>>> Libraries:
>>>>     wxWidgets 3.0.3
>>>>     libcurl/7.56.1 OpenSSL/1.1.0g zlib/1.2.11 libpsl/0.18.0
>>> (+libicu/59.1)
>>>> libssh2/1.8.0 nghttp2/1.27.0
>>>> Platform: Linux 4.13.12-1-ARCH x86_64, 64 bit, Little endian, wxGTK
>>>> Build Info:
>>>>     wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+
>>> 2.24
>>>>     Boost: 1.65.1
>>>>     Curl: 7.56.1
>>>>     Compiler: GCC 7.2.0 with C++ ABI 1011
>>>>
>>>> Build settings:
>>>>     USE_WX_GRAPHICS_CONTEXT=OFF
>>>>     USE_WX_OVERLAY=OFF
>>>>     KICAD_SCRIPTING=ON
>>>>     KICAD_SCRIPTING_MODULES=ON
>>>>     KICAD_SCRIPTING_WXPYTHON=ON
>>>>     KICAD_SCRIPTING_ACTION_MENU=ON
>>>>     BUILD_GITHUB_PLUGIN=ON
>>>>     KICAD_USE_OCE=OFF
>>>>     KICAD_SPICE=ON
>>>>
>>>>
>>>> Nick
>>>
>>>
>>
>

Attachment: signature.asc
Description: OpenPGP digital signature