kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Which file, board or footprint?  The board file by version.  The
footprint files (at least the footprints supplied by kicad) should
always have a model offset of 0,0,0.  Are there that many users with
custom footprints with 3D offsets that are not 0,0,0.

On 11/21/2017 10:53 PM, José Ignacio wrote:
> What if you open the same file again, how can it tell it's in mm or inches?
> 
> On Tue, Nov 21, 2017 at 7:19 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     I'm not sure I understand what the issue is.  Once an offset is changed
>     to mm when either a footprint in a board or a library is parsed, why
>     would it not be saved as mm.  If it isn't, then this is a bug.  Once the
>     footprint offset is converted to mm, there should be no expectation that
>     it will be correct for older versions of KiCad.  Is there something else
>     at play here?
> 
>     On 11/21/2017 04:26 PM, Oliver Walters wrote:
>     > Wayne,
>     >
>     > Not sure how you want to handle this but I feel that making a clean
>     > break and using "offset" for mm solves all the issues associated with
>     > embedded footprints without version info, as Maurice says above. Let me
>     > know if want me to implement.
>     >
>     > On Wed, Nov 22, 2017 at 8:24 AM, easyw <easyw@xxxxxxxxxxxx <mailto:easyw@xxxxxxxxxxxx>
>     > <mailto:easyw@xxxxxxxxxxxx <mailto:easyw@xxxxxxxxxxxx>>> wrote:
>     >
>     >     Hi,
>     >     first headache symptom...
>     >
>     >     Testing conditions:
>     >     latest KiCad patched
>     >     Application: pcbnew
>     >     Version: (2017-11-21 revision 8de70f3)-master, release build
>     >
>     >     If you edit a footprint adding 3D models offset and then
>     export it,
>     >     it will be saved with the new mm convention...
>     >     but when re-imported it will be read with deci-mils and displayed
>     >     with wrong convention...
>     >     Moreover if the imported footprint will be inserted into the
>     board,
>     >     the footprint will conserve the wrong values...
>     >     Those wrong values will be then saved with the new kicad_pcb
>     board....
>     >
>     >     On 11/15/2017 3:40 PM, Maciej Suminski wrote:
>     >
>     >         Hi Maurice,
>     >
>     >         On 15/11/2017 1:21 PM, easyw wrote:
>     >
>     >             Just a clarification request:
>     >
>     >             Kicad Stable has version assigned to 4
>     >             Previous stable had version assigned to 3
>     >
>     >             I imagine that next stable would have version assigned
>     to 5...
>     >             Am I right in supposing the next numbering release?
>     >
>     >             If I'm fine, with the proposed patch the new stable
>     release,
>     >             if assigned
>     >             coherently to actual releases numbering, will fail the
>     check
>     >             that is in
>     >             this patch; the new parser will then mess up all 3D
>     offsets
>     >             each time
>     >             the board will be saved/displayed...
>     >
>     >                 +            if(m_requiredVersion < 20171114UL)
>     >
>     >
>     >         I think you write this assuming the v5 file format will have
>     >         m_requiredVersion set to 5. If I recall correctly, we have
>     >         decided to use dates for file versioning and this method
>     will be
>     >         kept for v5 and later versions, so we should be safe here.
>     >
>     >             As I already stated the actual situation has no problem in
>     >             displaying
>     >             the correct offset in 3D viewer and the exporters are
>     fine...
>     >             The only 'issue', if we can say this is an issue, is that
>     >             the offset is
>     >             assigned to deci-mils and not millimeters inside the
>     >             footprint...
>     >
>     >             This is going to open big headaches for which enhancement?
>     >             My 2 cents
>     >
>     >
>     >         The solution Oliver has proposed looks solid to me, I do
>     not see
>     >         any potential headache. The patch has a very noble goal of
>     >         fixing one of the biggest KiCad sins - incoherence. I
>     think the
>     >         reason is good enough to commit the patch.
>     >
>     >         Regards,
>     >         Orson
>     >
>     >             Maurice
>     >
>     >
>     >
>     >             On 11/14/2017 10:55 AM, Oliver Walters wrote:
>     >
>     >                 Wayne,
>     >
>     >                 Please find attached updated patch set. If an old
>     >                 version is detected,
>     >                 inches are converted to mm.
>     >
>     >
>     >             _______________________________________________
>     >             Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >             <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >             Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >             <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >             Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >             <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >             More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >             <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >
>     >
>     >         _______________________________________________
>     >         Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >         <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >         Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >         Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >         <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >         More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >         <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >
>     >
>     >     _______________________________________________
>     >     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >
>     >
>     >
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
> 
>