kicad-developers team mailing list archive
Mailing list archive
Re: KiCad (macOS) wxWidgets fork
Could you share the config command you used to set up wxWidgets? I used:
but I’m getting a make error:
make: *** No rule to make target `../include/wx/osx/cocoa/stdpaths.h', needed by `basedll_appbase.o'. Stop.
I assume I’m on the right branch:
Jeffs-MBP:build jeff$ git status
On branch kicad/macos-wx-3.0
Your branch is up-to-date with 'origin/kicad/macos-wx-3.0’.
PS: I also seem to be missing a .gitignore file. Is that not in yet, or is that a symptom of something else?
> On 19 Jan 2018, at 16:49, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx> wrote:
>> On 15. Jan 2018, at 10:39, Carsten Schoenert <c.schoenert@xxxxxxxxxxx <mailto:c.schoenert@xxxxxxxxxxx>> wrote:
>>> We should make it obvious that it is a branch of wxwidgets for kicad
>>> specifically patched for macos to avoid any confusion.
>> based on my experiences in other projects I suggest to use topic and
>> prefixed branch names. I'd avoid the usage of capital letters.
> Good proposal, I like that.
> So, I created a branch
> based on the original WX_3_0_BRANCH.
> If at some point patches for other OS (e.g., the mingw patches) should go in, we can still rename it and remove the macOS part.
>>> 2) Commits
>>> The branch should always be rebased to wxWidgets changes, so all
>>> patches will stay at the top.
>> Rethink about rebasing to hold the branches in sync with upstream as
>> this breaks clones of your branches due smashed SHA IDs and people would
>> need to do a hard reset. Just merge any upstream changes as usual into
>> your branches, in case you want to address / forward your work to
>> upstream you also would do a merge request then. That's the typicall
>> workflow I know in such cases.
> Thanks for the reminder, I tend to forget that.
> So, no rebasing but merging.
>>> I still find it somehow difficult to see where original branch ends
>>> and own changes start.> Should we add some prefix “KiCad: …” to all commit messages?
>> I see no need to do so as you work on "your" branch and merge commits
>> are visible as that they are, I personally do some prefixing in my work
>> in the subject for the file, component, part, OS (...) the commit is about.
> I decided to prefix every change with “macOS: “, just in case the branch gets used for other OS in future.
> I reviewed all the patches and only applied what was still needed/valid.
> See end of the mail for details.
> For me, it compiles on macOS 10.12 and 10.13 (with macosx-version-min from 10.13 down to 10.7).
> The branch should be ready to use now.
> All macOS devs please test if you see any problems or if anything is missing.
> As soon as Adam has integrated it into the daily builds also the current build errors should be gone.
> Next step would be to adapt KiCad compile documentation and to remove the patches from KiCad source.
> @Wayne: Is it OK for you to remove the patches?
> Patches applied as in KiCad repository:
> Applied with changes:
> ==> See wxWidget ticket
> ==> See wxWidget ticket, changed to strip out styles in question
> ==> Corrected version with missing header
> No longer needed (already applied or other fix):
> Additional patches (not yet in KiCad repository)
> https://bugs.launchpad.net/kicad/+bug/1692352 <https://bugs.launchpad.net/kicad/+bug/1692352>
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp