← Back to team overview

kicad-developers team mailing list archive

Re: kicad_pcb, kicad_mod format change for daily build?



On 5/16/19 9:30 AM, jp charras wrote:
> Le 16/05/2019 à 15:11, Seth Hillbrand a écrit :
>> Hi Wayne-
>> Makes sense.  Should we plan on updating the file version number for
>> formatting changes in the future then as Rene suggests?
>> -Seth
> I am guessing Rene mainly ask for updating the file version number for
> formatting changes in footprint files, but footprint files do not
> currently include the file version number (although the parser accepts a
> version id).

This is something we need to address.  At some point during v6 we plan
to officially support for keep out zones and edge cut layers in
footprints so we should add version support to the footprint library
file format at that time.

>> Am 2019-05-16 09:02, schrieb Wayne Stambaugh:
>>> Hey Seth,
>>> I'm not sure the added complexity of a subversion buys us anything over
>>> just updating the file format version.  This particular change was a bit
>>> of an odd ball in that it didn't break anything as far as the parser is
>>> concerned.  I wish I would have quoted everything that is used a string
>>> in the original file format so it was obvious what is a token (keyword)
>>> and what is a string.  Hind sight is always 20/20.  I will not make that
>>> mistake with the new schematic and symbol library file formats.
>>> Wayne
>>> On 5/16/19 8:47 AM, Seth Hillbrand wrote:
>>>> Hi Wayne-
>>>> What about a "sub-version" tag?  KiCad can write it to the file but
>>>> doesn't need to parse it.  We reset it to 0 with each file version
>>>> update and then increment the subversion anytime we need to change the
>>>> file formatting.  External parsers that care about formatting can use
>>>> it.
>>>> -Seth
>>>> Am 2019-05-16 08:40, schrieb Wayne Stambaugh:
>>>>> Rene,
>>>>> It's probably a bit late now but Jeff's assessment is correct.  I
>>>>> understand your concern but technically this doesn't change the file
>>>>> format when spaces are used in strings it just makes it obvious that
>>>>> the
>>>>> information in the file is used as a string.  I'm not opposed to
>>>>> changing the file version but I'm not sure it buys us anything.
>>>>> Cheers,
>>>>> Wayne
>>>>> On 5/5/19 4:29 AM, Rene Pöschl wrote:
>>>>>> Even if the current kicad versions can read it it still makes problems
>>>>>> with version control.
>>>>>> For that reason i would request a file format verion update on any
>>>>>> change to the file generation at least for library assets as it has
>>>>>> direct impact on the library maintainance!
>>>>>> It makes it near to impossible to easily identify changes made by the
>>>>>> contributor compared to changes made by the new file format algorithm.
>>>>>> The reason for my report is:
>>>>>> https://github.com/KiCad/kicad-footprints/pull/815/commits/624037c1ca388506fca4d1d5b6b42e9f68157470-- 
> Jean-Pierre CHARRAS
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp