kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #41954
Re: Patch: Fixing a compile error on Power PC
-
To:
"Steven A. Falco" <stevenfalco@xxxxxxxxx>, Seth Hillbrand <seth@xxxxxxxxxxxxx>
-
From:
Tomasz Wlostowski <tomasz.wlostowski@xxxxxxx>
-
Date:
Tue, 27 Aug 2019 17:14:47 +0200
-
Arc-authentication-results:
i=1; mx.microsoft.com 1; spf=pass (sender ip is 188.184.36.48) smtp.rcpttodomain=lists.launchpad.net smtp.mailfrom=cern.ch; dmarc=bestguesspass action=none header.from=cern.ch; dkim=none (message not signed); arc=none
-
Arc-message-signature:
i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nnWGsZsK7npgtGcxAQ4gMqzyeyF618GZ+KSruXqg3pg=; b=TwOWryIZMKpwc3QY5WEZlVOWPF+hkERpEEEu4sJLh0Ln2SFW/7v1Qvxh0oWKUa6kKHCMXjHMaiNYfhiSI4ZFkMz6EoQDTeu6LgLTTD8SH/knfu0wPKMOW2Kt+EFopB/w3NmLFLUPJ+dr/UtyLwGJ7oCzZuPxQB9sR/0P7vH53Ex6VaBFQ5X5420NYL9cndmvbrODly5t2BNKr+zih9jOd8g59ekn/GePWlRRd9Nyp6vxK+jZE1q5N6IjuoWc4WcDrMWdd6iHlnYRa2iIpY/SiqqNkIe8IJtvTx1jCHARlWNAlzcO/eWydnyOPwM64cxB2g7fnrQr5enOOHSf/ckfqQ==
-
Arc-seal:
i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gXMWqvcWxwbUfBu4aUw4KIAxzkhVX/oJUeHuKzg2P+XCs+PWj8FY/deYjtHssU9AyP8YLp5Z0V0kvJxujrrpOVNcPQfSw3FYqOz952n3B1/ACBl++4xPE4o+PrHrt3KI3+ltUEmyqRvUCTxBV6h55zeyJwlYcVLx6xXn8q9BhhPsyC/eGliN/yybogIUL3q9N2xfkFLlMR/AY5O7jdld/LkIn6C39prs4wIMXZ2HJiQPMxjwIf80QwGOR3yIAGvCU70se+l4QyKzZipBHWeXy6Usi9tiqAt0zAhQG3RCkI12ady1XB0nWdjNjFjKwxGP/Pn7xGiBxmbSpbHYaOBg0A==
-
Authentication-results:
spf=pass (sender IP is 188.184.36.48) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
Autocrypt:
addr=tomasz.wlostowski@xxxxxxx; prefer-encrypt=mutual; keydata= mQINBFRh3ssBEADmCSrn6qwXrSwI2/LcFSv0aXNHrUQ0MyOAHAW1Rn3LNXLcSCxep1w0iH8q M+ag0XxRVf87DGqjv8wKLGc8nIkGtrMSOuiF+hsrtjAiIrOyOipTABLapqGVj1Dm/26NCtiM /0ZU3XjKcSS5rrj4epKaTM0qW7xp6VceZgH79MbiSCjrt/r9Yhx4tGbWBaCSgTOUHwNB3/Oq 0E5VjU5SAQBQhwG71mES/xaIIUxtfxAPLxpvaq81cjTuT2VQ30T65fSDVikwXrc7M/a2hUG0 nyreo4CktY4pazofQpBA8f8gDPOY1CezY1o1or1Ey6Td/YM/G/Q2G9RZZTjPgD1KRdWIC+nG oCP0lcrMh8Ee+JgR2X7iAAfyVuKAeokxkGnCLon2qiuRG6yAGsEeunJDSd0XtBXzn71GqQH6 0NJzndNoI2PptbHMgc6bINbODkl/RFjVLVGMxDQbgxui2inpjayUZVCQ6SHiiY8BMJrpvTWK GvmgXllxGw+9IQ51u/I0W6hBdy0W/P2oXrP7V2GPDdvyIGJaecjvbkEnD1AbRvxlOjVTGFnC cW08ohzNHGfQK/MXaIpnZAWzRqJz8Wx13KkrdN1hT5quJtaHsvuxBclgHmzbqLlfvLnU7iOa tdN/JzL4L3czEFLJhnHOf9e5zd8yith9vGLUwPxjCzQvz5kBEQARAQABtC1Ub21hc3ogV2xv c3Rvd3NraSA8dG9tYXN6Lndsb3N0b3dza2lAY2Vybi5jaD6JAj4EEwECACgFAlRh3ssCGyMF CQlmAYAGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEMD02zLS2+sBdxkQAM3Nwk6cU8JT A0uR83NsQEUWjoGboIkVtO5amqWqWGLBguolhEt/NTuzQtmD6rFFhPcOpXDKRKdd6ySdlUB7 8XIgQQTEex6uQpWWV/cLACz6a0u0BONA+VPFzRpWSpOMKpCOcm7izGX9H4CZu4f+bqhL3zaC 38Ki5XxyyioGUzyWd/tw84nz2JgrP1zcYih0Qq82ooO1sRIUrJrm7onb4dH29p7d12uGiQZt go+xeYcDW3TlN4m2tmd7l/JqsD8F0CqtvWrGMsdbr1NE5Y2vyIpG3rkkCiTrlUs0SFyqAC7L qRswP6UZa7enNMhRtJN7eqyrya8J7deRTB6qubP8kTGTt+UTlIgivSqThEN9cJu4cWOsdr3X /D9h7aej1jDSerwKIm7UdmrjkOsgUiZhFMphdAgelmfcVdl7CjsqnnYa5eeeVfEMeT3Fv79V qUcg6LfwUGB56gO4OsnMLGCzCbn6kuwbtlCcV10MsTVzvKNFOrs3mm+yZ2msdLJSV2QMNtHW EVXJV2Tlye+XiYtljdyA6GthK+T/Z9qj8nblunMMN9TwCPkIzzKgyKPxIup/MV7CzN2y8nbp BqkFhApTlXt+NflNdqkfqrWcm+XDXbTwvUzFrKVc8QczpVOMuk7kS+MwxtGGEL6QuML/W8hb k1iEeeAQNiNorHshYTJzGb+luQINBFRh3ssBEADQpjP/NdQTZFh11UxsKAOM3KVPSjYxyOEO Gd65/klc3ZBTXJAaC2XmUhYU/kzhyJU7/dd+ywhsLYsWB21mVucAsANra1BkTFXPQFPQwsPP 15QnWQQwFdX7AoMZYceiXqNSWc48DvnXqlUB8TqzB3dSHys9tzfmc+2TDAlM/TpYKWTtY9Fc 2xsx3ZvOzHE1wi6KmdMuK5qc5QBWY16FJtcFA2D5scd24Zy2cO+QS7fDuQHVQpuV+y8unUQC l3VBdOb21WpYrkyUCJU5yRxTP7kbHOIaNyr6S05zArg0TtEfaqCSDOrljxzxSqLtgnD35enE G9/lvQbX8rG0nR1W4ZnhnEx0hAJk2eJ7v9X2Fiq+3rYiEhUsthfBexxoailNxrFIYFr1qBiG zj1HvzoEQZ0Mz/WU156JJBSKAg1IrWzKswIrcv1FoRVhISiEo4nfJslBthZbJjGJ5veYSU5V K4yUNEvcG98+Z4YKFLREXBq6V1AmiFUVbZ1FblK8TGvQaQ3YJlOWEtDA1yrHnujz5wgxtBSM pUsNApQOs2c0MaksfIgkM1McRDwTemup+wmPJ2U8Hvb5A6lI1G+iiUrXPYahdy8XRMxyM1aU xQz53A8Ex+YK/Qn/16k9BZYs/0k3tXb+WBFBcsq732oCo6n4hbfCoG4gYDn7jlEhnm/aQ1Vr eQARAQABiQIlBBgBAgAPBQJUYd7LAhsMBQkJZgGAAAoJEMD02zLS2+sB6kgQAM4V4jIUJo98 rbCU0Yy8YLahwQK5TynS8+zsQ/s9q+aYT8qWzdcjavfRKA3VArGP8qYBXRIQW7QbceSChTOG hhai+5nIJbWhGXVfEUtZ2txahcY2ecfsDEkvCOK7pLKsCq7eYQzMHV8ZPwGWPq+hZa+6msHh R2yUHo6NV2u2HjVJROaM2nUSZT6hOMhzp+zYwl1XEZKqo+QxDtLWJQ66MZIOAngyWN9/ePUJ 0dxG6V+r9MjgHS/OtVlgCKtvAYJCRGcGiSaL+wjhiaZ1/nwBAL0mwN2UaoP+oYjI09J5/Mff tbtQQHMQwRxy31b6N1ZFunnVkR0MeBlT8JtUI31zroRoQ/4u0+wXTYaeTANa0R73Y/m8aIhE sj2ZDD6NISA0Yxnm1rXUyJZosrcS5WjrpgjAjQvkFpm7Sx8Sx+QWpS+DcL8rJntzwL9cPHPA 3tutTbZ9vQrH20TT8Z4nFzTvytFKb5bydF92Fawph2NjFcwzMi/6i37tS1q1X93ky10vq2M4 MaTxIwyjENy6GT5mPh2YlKhWHN5K+8K7rf6QBsvud+SdN3T1AEJojZEYIvxXi0MMpfB4iqlu z+oUbkdDqZonG9QZIME1/BJ3y5oVp5h1r6+vs58a5p/lHjurNYMgbNmWUAcW3trFwXWJispd DhAcLoHO+yCvkKJabrfOZoa2
-
Cc:
KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
In-reply-to:
<75a83f7a-4b8e-7c57-d392-27f77de79234@gmail.com>
-
Openpgp:
preference=signencrypt
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
On 27/08/2019 16:18, Steven A. Falco wrote:
> On 8/26/19 4:16 PM, Seth Hillbrand wrote:
>> On 2019-08-26 16:05, Tomasz Wlostowski wrote:
>>> On 26/08/2019 17:24, Seth Hillbrand wrote:
>>>> Agreed. That looks like it may be have been a rebase issue as the
>>>> commit was for MSVC and shouldn't affect PPC.
>>>>
>>>> @Tom, shout if you see an issue here. I've pushed the patch to master
>>>> in the meantime.
>>>>
>>> I don't see a technical issue, but rather a practical one: why Linux
>>> distributions dictate us what architectures we should support?
>>>
>>> I've never seen a machine with a little-endian PPC.
>>>
>>> Tom
>>
>> The LE variant is the PPC future starting with POWER8[1][2].
>>
>> [1] https://www.phoronix.com/scan.php?page=news_item&px=POWER-PPC64-Discontinue-Fedora
>> [2] https://developer.ibm.com/articles/l-power-little-endian-faq-trs/
>>
>
> I don't think it is a question of LE vs BE. The issue is 32-bit vs 64-bit.
>
> On a 64-bit PPC machine, gcc defines both _ARCH_PPC and _ARCH_PPC64, so the test in libcontext.h was wrong, and resulted in both 32-bit and 64-bit code trying to be compiled simultaneously. My patch simply makes it "either 32bit or 64-bit" rather than "both 32-bit and 64-bit at the same time".
>
Does anybody here have a PPC machine to test this? Preferably one with
working OpenGL?
Cheers,
Tom
Follow ups
References