kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #41955
Re: Patch: Fixing a compile error on Power PC
-
To:
Tomasz Wlostowski <tomasz.wlostowski@xxxxxxx>, Seth Hillbrand <seth@xxxxxxxxxxxxx>
-
From:
"Steven A. Falco" <stevenfalco@xxxxxxxxx>
-
Date:
Tue, 27 Aug 2019 11:18:31 -0400
-
Autocrypt:
addr=stevenfalco@xxxxxxxxx; keydata= xsFNBFxDhRcBEAC6Imgmt25S/CEOFsv+gHf52PQavJDRWK3pytsiD91DUmZnIwpWkYwJiKo8 E8nYMxw8R4g0YhCXCc7DwYXUnHQgIaO3SnLryLGZntJUuCuZxMjE4YEGOhq0mePnlhz1gcMQ 2TOAvBVXVg2841rEzGWZlXIg53eBavAobB9oJG2/5MyDzyB7d7nhvpuDuEDSKbIR69tbtTQC EQ86hZM+mUvekkU6FiMJQEU4hqJBF4BKmp+0mZ+dN1ZjRPCmCcShj9c6W6n9YITZuOPEBhIB v88m+3YQBkzsPu6tGjAXlk2H4jrkry9BQK27Ddn1N3Gz+oRDkX/UVd/jY2m0A0gxMi++N0wO K2DTShAAO4Imdrb5G1K+UJ0kNbLnkO4CmVVBD/yvnZo1WLRh4MGgUW8J+l1EPjQZvJHSOdIU 7HoLkWDoH6CZg2UqSNrhYIfJJD/K1H0gcXfCVEVhbDlQxclhiWID+8wQ9c0fVa/EabU0zBXJ sLBkO6tEtSaiLKHaIqkYGXCQxvpwHQwPR5ZNt9DXrRkmVm77ymh2jLJbHVv8XgtOJE7XkXn8 3Iv9iUFESd/1xZFUB51eVu+8aDjxDkwaqzlf/rUiOV+S8KZ4//gc1CC0EhqFCRFSZEJsblR1 c0wdF86NVFqeH+g+Z6n/yLKJWAvRLuw8w9JlWnoTMnIzS77J/wARAQABzSdTdGV2ZW4gQS4g RmFsY28gPHN0ZXZlbmZhbGNvQGdtYWlsLmNvbT7CwY4EEwEKADgWIQSDrcEoXtTdcq9JzuJt oCQy7y8uvgUCXTMy7gIbAQULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBtoCQy7y8uvi7h D/0dnzzMCiNvv89bx53CPPhfKJ2HALCTU3RJCD2yUkvJImDq/EWewUyYe2nX+fXJt/RV/3n1 LnU2MmpHBoE2usTSSxzWP0nmWSHK1BVLgd+JEPKPpNRgcm0LXWOYvXxAw011Jtb/pLppXqS4 oH7T6IR0w2dPAAhWLSOMegGufKHdYd6zyoflQOEeMtKN2P4HhdhIixL8goltpTOnAZGuDbwD 7KM/BUBo7R4yvocebHMMNQI+WrExnJ7CohKfPbIMQOdWoETIt/Cn+lkGoSakc5PM+KkKww8L dx1j7yYnRhc2cz2Kcsi+X1f2k+YbvyEv4OPbYmYVsKZsKIedMSHRJmKtaPY4NpGnyj9l6JuF sotXMJg9l4GVqB2VTg75BFEWUFo9kfoTTynWIUAcDRlrhZ1Z/U9VqaLo2ASKRzoWhCSm6o+e ztZobUEVidfwwfK6vuLy5KzOJpGFG3CratvTWhijHvacBMiYpo9UJQ5gRmBwOxn080WwfdbI VRCY8Kbo2grMyK0KlU3GF6WS0UA5b/NfFvpu6CxDaZcwqwPP+XVSosrZXsiWQ3PaOgO6iB3O PWhqxmMaEPAbRgpqEiW57VTVFiYeTKct0R+vz3VPFHiFTjxqZ+UqF2qA62WQiNv6cSxvj6XI foegXLii1wLQn42uVvRM5e2F7IomB7I1QXAIoc7BTQRcQ4YaARAA8/dQrMEaTlvwA189gQnT 3RiJtzxw6siDoI4IYxVCcCzds3waa/AGiT6+gUj+1/zK1iXObVToUJYB552B6Y5bvDkkZoyb +7pKHj9VKCtuK2NGHQAxfz+VZ6MJRyqdOKbjyND36VenJ6+ihx7G6zevtDsfs5cCkuh90riu Ky7JGWFvdwI1i59g85YlScA5EBCmkcK096NL0LrU8eQ4rs8AXK6ryrzDYEEmGc8lO0vSzJYx Dts9qwfFU/iYF/bfntrXBu+C5gcD25pQQjFt0ZRjbBI7FzL4ouzgqq3ZLy/5pTMo3DT79fQf SjGcBXMfJ+IkCte4kqR8VMNiKrhmIKiYCRSrpsL5iMj+WpYs1I0MiSEiPzJSZVgjBJ9vDfb8 Kk3HMouU50pk2vw1cTr58h9HuCvt1KCUNhUrREngJadEKkxS7qS+01tJHFBB2kN4d+6VUSjQ G2OBJQhys0o6NUIR1Tvaq8L7Dzuxq1G5e4xP+tc1hCBTD3EFKonLFKJE9q/RCPOyGc8erzGQ 3PbSb87jdZ55lMn/0oEhi640h7IYbdmOYsg1T1QNnDlBeH7yB3TMvKjR9X/BnidYvzbGA0Lp I+NAcBnedvcdSKwHY9ddhCNRk1gG1id3X7PZ/KBWoyJUoBsbpq9ijATv2P8pve8XmV4iafp7 FSL7IYWPA3yzgskAEQEAAcLBfAQYAQoAJgIbDBYhBIOtwShe1N1yr0nO4m2gJDLvLy6+BQJd F5pIBQkKOhWuAAoJEG2gJDLvLy6+HEsP/0aQxisD60l7QLlEBEhbSNJ4wBPKXeYjUN/AQaDU DcnTZ8i+IiNRpZsmSB82eDy3xagT+uG+dUFPaJ7VYG9HY1G2fN+1mfaoONFhF4sGDrvtI4tD 6s9qJ+62mkRz6N/V8cNHU8PMmD/dnhNa9sF4eVeqWaCWuaQXLij5P9UVC2vr9ecNkgSdcB81 IwVAnXjErtMnozw81CQUcC7CiBXWniPTj74TWafwFA7lbTpyX5vQ6ETOcmZ+pdFVqjdb6BjE TZYNMmde+YiFNGaHru37/1Dijl5ur/dc5ZZ4V/SQ+rQr1rf+VHwoxo7lyrbtDT8+x3kpfS5p ZYBIyl4IDdwmNnIYBWOve8Eeh5IX34Ww92T4TCN31/YuyzlD5m+rajE1tMq6vPlSB0gMPwSg VStS+RIDXcbiU6BaeTCzhisbyZHzk1xwh3c2p9TlN2OHBC6g3QKGQI2v0XrlHpV/qeqfu3j5 0h2fgxjMA6FiFdnbKGXY1W/a6WNZW6XohCSwQlHWm2eybIyjfhaHkv3H+gWBXxink6L7PP9h fX/7OqQOP5Svj0hRGaWGKNrrGwSly/7o9rY9ci1U8ObfdKHsgPmGUcuB7PsObAsxB8aTuSmS 0FDx+sy7LYmcKOrGh9S73xsCPHZ4+FJxgKqp6O+hyYoW4fCKczpuzABgJUM0fwR4l6DV
-
Cc:
KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
In-reply-to:
<dd461d19-b6e5-e480-67ff-4d6c8e514f38@cern.ch>
-
Openpgp:
id=83ADC1285ED4DD72AF49CEE26DA02432EF2F2EBE
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
On 8/27/19 11:14 AM, Tomasz Wlostowski wrote:
> On 27/08/2019 16:18, Steven A. Falco wrote:
>> On 8/26/19 4:16 PM, Seth Hillbrand wrote:
>>> On 2019-08-26 16:05, Tomasz Wlostowski wrote:
>>>> On 26/08/2019 17:24, Seth Hillbrand wrote:
>>>>> Agreed. That looks like it may be have been a rebase issue as the
>>>>> commit was for MSVC and shouldn't affect PPC.
>>>>>
>>>>> @Tom, shout if you see an issue here. I've pushed the patch to master
>>>>> in the meantime.
>>>>>
>>>> I don't see a technical issue, but rather a practical one: why Linux
>>>> distributions dictate us what architectures we should support?
>>>>
>>>> I've never seen a machine with a little-endian PPC.
>>>>
>>>> Tom
>>>
>>> The LE variant is the PPC future starting with POWER8[1][2].
>>>
>>> [1] https://www.phoronix.com/scan.php?page=news_item&px=POWER-PPC64-Discontinue-Fedora
>>> [2] https://developer.ibm.com/articles/l-power-little-endian-faq-trs/
>>>
>>
>> I don't think it is a question of LE vs BE. The issue is 32-bit vs 64-bit.
>>
>> On a 64-bit PPC machine, gcc defines both _ARCH_PPC and _ARCH_PPC64, so the test in libcontext.h was wrong, and resulted in both 32-bit and 64-bit code trying to be compiled simultaneously. My patch simply makes it "either 32bit or 64-bit" rather than "both 32-bit and 64-bit at the same time".
>>
>
> Does anybody here have a PPC machine to test this? Preferably one with
> working OpenGL?
>
> Cheers,
> Tom
>
I actually tested it on a PPC64LE virtual machine. While it is naturally slow on a VM, I was able to launch KiCAD with my patch, and it worked perfectly.
Steve
References