kicad-developers team mailing list archive

[Ian McInerney <Ian.S.McInerney@xxxxxxxx>]

This looks to be Debian specific. The build logs for the most recent Fedora
build [1] show -DNDEBUG in the flags but the Debian build log [2] does not.
It looks like the release type is not being specified properly in the
Debian packaging since they are forcing the release type to None (they use
custom flags and do not want CMake to actually set any flags itself
apparently [3, 4]). Therefore, we will need to add the flag in manually.

Carsten, I just made a merge request on the Debian packaging repo to do
this. Can you take a look at it and comment? After this change, I see the
-DNDEBUG appearing in the compile command when I do a local build on my
machine.

-Ian

[1]
https://kojipkgs.fedoraproject.org//packages/kicad/5.1.4/5.fc32/data/logs/x86_64/build.log
[2]
https://buildd.debian.org/status/fetch.php?pkg=kicad&arch=amd64&ver=5.1.4%2Bdfsg1-2&stamp=1570912510&raw=0
[3]
https://github.com/Debian/debhelper/blob/master/lib/Debian/Debhelper/Buildsystem/cmake.pm
[4] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=701233

On Wed, Oct 23, 2019 at 4:42 PM Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:

> I see -DNDEBUG defined in windows release builds where CMake is
> configured with -DCMAKE_BUILD_TYPE=Release.  Is this not the case with
> Linux and/or macos?  Did we make the mistake of doing something like:
>
> set( CMAKE_COMPILER_FLAGS "-foo" )
>
> instead of:
>
> set( CMAKE_COMPILER_FLAGS "${CMAKE_COMPILER_FLAGS} -foo" )
>
> in one of the none windows build code paths?  Doing this will wipe out
> any compiler flags set by CMake.
>
> On 10/23/2019 11:16 AM, Ian McInerney wrote:
> > It looks like the build flags for KiCad are not getting NDEBUG defined
> > to remove the assertions. We should add -DNDEBUG to the flags passed
> > into CMake alongside the Debian flags.
> >
> > -Ian
> >
> > On Wed, Oct 23, 2019 at 6:38 AM Carsten Schoenert
> > <c.schoenert@xxxxxxxxxxx <mailto:c.schoenert@xxxxxxxxxxx>> wrote:
> >
> >     Hello Seth,
> >
> >     Am 22.10.19 um 18:10 schrieb Seth Hillbrand:
> >     > Why do you have "hardening=+all" enabled?
> >
> >     mostly because this is the default for building binary packages with
> >     enabled hardening.
> >
> >     https://wiki.debian.org/Hardening#Using_Hardening_Options
> >
> >     > This is likely where the assertions are happening.  We might
> consider
> >     >  "hardening=-all,+format,+fortify"
> >     I'm not that deep into the details here or at least would need to
> keep
> >     reading some stuff. But as far I've understand the hardening flags
> >     should have no effect on this.
> >
> >     Maybe Simon can give some enlightenment on this?
> >
> >     --
> >     Regards
> >     Carsten Schoenert
> >
> >     _______________________________________________
> >     Mailing list: https://launchpad.net/~kicad-developers
> >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     Unsubscribe : https://launchpad.net/~kicad-developers
> >     More help   : https://help.launchpad.net/ListHelp
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>