kicad-developers team mailing list archive

[Seth Hillbrand <seth@xxxxxxxxxxxxx>]

I have conditionally adjusted the signature based on a secondary tag that
also seems new since NGSPICE34.  We can't adjust the API without packaging
sharedspice.h ourselves, which I don't think we want.

As an aside, it would be very helpful when typedefing a new value to
include a define (like #define HAS_NG_BOOL 1) with it.  That would allow us
to test for the new signature when compiling.

Best-
Seth

On Wed, May 5, 2021 at 1:46 AM Holger Vogt <holger.vogt@xxxxxxxxxx> wrote:

>
>
> Am 04.05.2021 um 23:32 schrieb Seth Hillbrand:
> > We can adjust our interface to cope with the change to int as an
> > underlying type.
> >
>
> That is great. Thus we may avoid any potential problems.
>
> > However, one concern is that the typedef exists unscoped inside a header
> > file.  The term "BOOL" is relatively generic and so there are likely to
> > be some conflicts with other libraries that use this term differently.
> >
> > Would you be able to scope it with a "using" keyword, or, alternatively,
> > with a less common term such as NGSPICE_BOOL?
>
> That's what I will do immmediately for the ngspice master and pre-master
> branches.
>
> Btw I do not see this discussion in the kicad-developers team mailing
> list archive. Does is add to a very old thread?
>
> Holger
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


-- 
[image: KiCad Services Corporation Logo]
Seth Hillbrand
*Lead Developer*
+1-530-302-5483‬
Long Beach, CA
www.kipro-pcb.com    info@xxxxxxxxxxxxx