kicad-developers team mailing list archive

[BERTRAND Joël <joel.bertrand@xxxxxxxxxxx>]

	Thanks for your patch.

	Nevertheless, after make clean && make, build process now aborts with :

[ 47%] Building CXX object
eeschema/CMakeFiles/eeschema_kiface_objects.dir/sim/ngspice.cpp.o
In file included from /home/bertrand/git/kicad/eeschema/sim/ngspice.cpp:31:
/home/bertrand/git/kicad/eeschema/sim/ngspice.h:138:35: error: ‘NG_BOOL’
has not been declared
  138 |     static int cbBGThreadRunning( NG_BOOL aFinished, int aId,
void* aUser );
      |                                   ^~~~~~~
/home/bertrand/git/kicad/eeschema/sim/ngspice.h:139:47: error: ‘NG_BOOL’
has not been declared
  139 |     static int cbControlledExit( int aStatus, NG_BOOL
aImmediate, NG_BOOL aExitOnQuit, int aId,
      |                                               ^~~~~~~
/home/bertrand/git/kicad/eeschema/sim/ngspice.h:139:67: error: ‘NG_BOOL’
has not been declared
  139 | atic int cbControlledExit( int aStatus, NG_BOOL aImmediate,
NG_BOOL aExitOnQuit, int aId,
      |                                                             ^~~~~~~

/home/bertrand/git/kicad/eeschema/sim/ngspice.cpp:635:5: error: ‘int
NGSPICE::cbBGThreadRunning’ is not a static data member of ‘class NGSPICE’
  635 | int NGSPICE::cbBGThreadRunning( NG_BOOL aFinished, int aId,
void* aUser )
      |     ^~~~~~~
/home/bertrand/git/kicad/eeschema/sim/ngspice.cpp:635:33: error:
‘NG_BOOL’ was not declared in this scope; did you mean ‘BOOL’?
  635 | int NGSPICE::cbBGThreadRunning( NG_BOOL aFinished, int aId,
void* aUser )
      |                                 ^~~~~~~
      |                                 BOOL
/home/bertrand/git/kicad/eeschema/sim/ngspice.cpp:635:52: error:
expected primary-expression before ‘int’
  635 | int NGSPICE::cbBGThreadRunning( NG_BOOL aFinished, int aId,
void* aUser )
      |                                                    ^~~
/home/bertrand/git/kicad/eeschema/sim/ngspice.cpp:635:61: error:
expected primary-expression before ‘void’
  635 | int NGSPICE::cbBGThreadRunning( NG_BOOL aFinished, int aId,
void* aUser )
      |                                                             ^~~~
/home/bertrand/git/kicad/eeschema/sim/ngspice.cpp:635:73: error:
expression list treated as compound expression in initializer [-fpermissive]
  635 | t NGSPICE::cbBGThreadRunning( NG_BOOL aFinished, int aId, void*
aUser )
      |
      ^

/home/bertrand/git/kicad/eeschema/sim/ngspice.cpp:646:45: error:
‘NG_BOOL’ has not been declared
  646 | int NGSPICE::cbControlledExit( int aStatus, NG_BOOL aImmediate,
NG_BOOL aExitOnQuit, int aId, void* aUser )
      |                                             ^~~~~~~
/home/bertrand/git/kicad/eeschema/sim/ngspice.cpp:646:65: error:
‘NG_BOOL’ has not been declared
  646 | NGSPICE::cbControlledExit( int aStatus, NG_BOOL aImmediate,
NG_BOOL aExitOnQuit, int aId, void* aUser )
      |                                                             ^~~~~~~

make[2]: ***
[eeschema/CMakeFiles/eeschema_kiface_objects.dir/build.make:2846 :
eeschema/CMakeFiles/eeschema_kiface_objects.dir/sim/ngspice.cpp.o] Erreur 1
make[1]: *** [CMakeFiles/Makefile2:3021 :
eeschema/CMakeFiles/eeschema_kiface_objects.dir/all] Erreur 2
make: *** [Makefile:182 : all] Erreur 2

	In my case, NGSPICE_PACKAGE_VERSION is defined in sharedspice.h  thus
NG_BOOL is never defined in eeschema/sim/ngspice.h.

	Regards,

	JB