← Back to team overview

kicad-doc-devs team mailing list archive

Re: Keyword "_T" for translations?

 

Le 03/09/2016 à 14:46, Wayne Stambaugh a écrit :
> On 9/3/2016 8:42 AM, jp charras wrote:
>> Le 03/09/2016 à 14:30, Wayne Stambaugh a écrit :
>>> On 8/31/2016 3:14 PM, Carsten Schoenert wrote:
>>>>
>>>> Am 31.08.2016 um 21:08 schrieb Carsten Schoenert:
>>>> [...]
>>>>
>>>> To be more precise
>>>>
>>>>> $ git grep -n " _T( \""
>>>>
>>>>> 3d-viewer/3d_cache/dialogs/dlg_select_3dmodel.cpp:143:    wxButton* btn_OK = new wxButton( this, wxID_OK, _T( "OK" ) );
>>>>> 3d-viewer/3d_cache/dialogs/dlg_select_3dmodel.cpp:144:    wxButton* btn_Cancel = new wxButton( this, wxID_CANCEL, _T( "Cancel" ) );
>>>>> common/dialog_about/aboutinfo.h:97:        copyrightText.Replace( _T( "(c)" ), utf8_copyrightSign );
>>>>> common/dialog_about/aboutinfo.h:98:        copyrightText.Replace( _T( "(C)" ), utf8_copyrightSign );
>>>
>>> Does anyone know if the copyright symbol should get translated?  I never
>>> really thought about it but I'm guessing it doesn't.
>>
>> I don't think it should be translated (I am talking only as French translator).
>>
>> Moreover, these lines are conditionally compiled:
>> #if wxUSE_UNICODE
>> ...
>>
>> Just remove this code.
>> I am pretty sure wxUSE_UNICODE is always true.
>> Because I don't think kicad can work in ANSI mode  (if still exists in wxWidgets >= 3.0).
>>
>> Thanks.
> 
> I thought so.  I believe as of wx 3.0 we should not be using the wxT()
> macro for strings that don't need translated.

For new code, I do not use anymore wxT() since some time for strings that don't need to be translated.
Strings are just quoted, especially strings like debug messages, or some error messages (roughly
debug message) related to parse issues when reading files.



-- 
Jean-Pierre CHARRAS


References