launchpad-dev team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Celso Providelo wrote:
> On Tue, Aug 18, 2009 at 3:17 PM, Aaron Bentley<aaron@xxxxxxxxxxxxx> wrote:
>> I know that Jobs provide their own queue system, so I don't know whether
>>  BuildQueue duplicates that.
> 
> It possibly duplicates the queue infrastructure itself, and
> additionally ordering/re-prioritizing which doesn't seem to be
> possibly with the current Job table.

So it seems like we've already got the duplication, but what you're
proposing could be a step towards unification.  That sounds positive to me.

Job doesn't provide an ordering mechanism, but BranchJob provides
arbitrary metadata via the JSON field, so you can plug one in if you want.

You could also perhaps use Job.scheduled_start for ordering.

The JobRunner doesn't require that its jobs use the Job table, only that
they implement IRunnableJob, so it could also be possible to implement
that on top of BuildQueue records, if you wanted to do that later.

> Some of Job aspects doesn't fit Build very well, for instance:
> 
> * Requester
> * Status
> * Finished
> 
> because BuildQueue records are dropped once the job is complete and
> the persistent information copied to the Build record itself.

One option would be for the Job to create the Build record.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqLBUIACgkQ0F+nu1YWqI33UgCeIbxah5tmWucitXLXluobd6JP
nlsAoIV3Tjqv7i5lSZQGusRJf0Gk1pSo
=KY8q
-----END PGP SIGNATURE-----