launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Review: Approve code

Thank you for this glorious branch Ian.

I don't think "please" is required on line 68, the application will not be polite it you make a mistake.

The edit action must follow the value that is being edited. When a bug is marked as a dupe, the video shows the edit icon leads the line, which implies the change the whole bug, but the user wants to change the value (the duplicate bug number) Line 884 of the diff might be the issue. I think this moves the edit link after the bug number:
            dupe_span.setContent([
                '<span id="mark-duplicate-text">',
                'Duplicate of <a>bug #</a></span>',
                '<a id="change_duplicate_bug" ',
                'title="Edit or remove linked duplicate bug" ',
                'class="sprite edit action-icon"',
                '>Edit</a>'].join(""));

I see an opportunity on Line 1024 to stop implying the users' previous action caused the page to show a warning message. We could use this instead.
    <p class="block-sprite large-warning">
-- 
https://code.launchpad.net/~wallyworld/launchpad/bugpicker-search-button-1031544/+merge/117839
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.