← Back to team overview

openerp-community team mailing list archive

Re: [OCA] PRs for standard files on migrations

 

I have no strong voice for any or other approach, becuase it's a nuisance
to wait for approvals, but also there are some things that people has
catched in the review process (incorrect branch for Travis testing,
incomplete README description or flags, etc).

I would bet for something in the middle: make PR, wait reviews for 3 days,
and then proceed with the merge.

Regards.


2014-07-12 12:04 GMT+02:00 Daniel Reis <dgreis@xxxxxxx>:

> My understanding is that everything in the migration spreadsheet is
> considered migration work and thus doesn't require PR approvals.
>
> DR
>
> No dia 12/07/2014, às 07:09, Guewen Baconnier <
> guewen.baconnier@xxxxxxxxxxxxxx> escreveu:
>
>
> Le 12 juil. 2014 00:37, "Holger Brunn" <hbrunn@xxxxxxxx> a écrit :
> >
> > Ladies and gentlemen being concerned with the bzr->git migration,
> >
> > we have a rulebook to do the migration, and a rulebook to handle merge
> (now:
> > pull) requests. The migration guide is not decisive, but most people
> including
> > me do the necessary changes as a PR. which stalls a lot of migrations
> because
> > either there's not enough thumbs up or thumbs up with nobody to actually
> pull
> > the proposal. Wouldn't it make sense to allow the migrator to do
> non-reviewed
> > direct merges of the .* files?
> >
> > --
> > Therp - Maatwerk in open ontwikkeling
> >
> > Holger Brunn - Ontwerp en implementatie
> >
> > mail: holger@xxxxxxxx
> > web: http://therp.nl
>
> +1
> Migration is part of the maintainers role and they should be able to
> proceed with the migration/maintenance tasks by themselves. This is also a
> matter of time. The migration is still running and the more long it will
> take time the more it will be painful and difficult to understand for
> contributors.
>
> By the way, there are still projects waiting for a maintainer and still
> maintainers that did nothing on the migration. Thanks to them to put their
> name on a few projects on the migration spreadsheet.
>
> Cheers
>
> _______________________________________________
>
> Mailing list: https://launchpad.net/~openerp-community
> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp
>
>

References