Hi Nio
(inlines)
On 04/28/2016 05:42 PM, Nio Wiklund wrote:
Hi Israel,
[replying inline]
Best regards
Nio
Den 2016-04-28 kl. 22:26, skrev Israel:
...
I hope to gradually get used to these new(?) bash built-in commands.
I think they are better to use in situations like ours where we are
trying to make things fast on old computers.
......
It makes sense when you tell me these commands. But sometimes I'm
losing all hope, when we are fighting bugs in code that used to work.
Yes, but it worked for the terminal + dialog version
And now (revision 229) I tested and things work
Anyhow.... with that code gone *revision 228* should completely fix
this
issue. I will test it as well. I have been testing the basic
installer
mostly, so I will test advanced on this one only, since I modified
only
the advanced code.
Let me know if it works for USB drives, as well.
The OBI-istalleer is getting better :-)
Now it was possible to get into gparted via the built-in sequence. I
could add the labels obiroot and obiswap and continue with the
installation. The installation worked, and the installed system works.
But there are still bugs.
1. I cannot select root partition and swap partition manually (in the
zenity menu). It looks like I select, but nothing is changed. The
original selection remains. If root and/or swap are not selected by
the partition labels, they are impossible to select. At least I don't
know how to do it with the OBI-installer. It seems the mechanism to
store or propagate the selection from the menu has failed somehow.
This worked before you started to fix the problem of 'moving the
desktop' with wmctrl.
Yes, I found the problem!!!
select-part2
HERE is my fix. It took me a while, because the code you had worked,
but made no sense at first until I tested things quite a few ways until
I discovered what you meant to do (at least I think)
You were making sure that the 'X' in sdX is a letter
## check answer for something like sda
## s="${ans:0:1}"
## d="${ans:1:1}"
## a="${ans:2:1}"
## [[ "${ans:2:1}" == [a-zA-Z] ]] checks to make sure it is a letter
if [[ "${ans:1:1}" == "d" ]] && [[ "${ans:2:1}" == [a-zA-Z] ]]
then
###etc
fi
This is the code that was there
if [ "${ans:1:1}" == "d" ] && [ "${ans:2:1}" '>' "_" ] && [ "${ans:2:1}"
'<' "~" ]
then
## etc
fi
Which made no sense to me....
I also replaced (uses 2 external programs twice)
rootpart=$(grep obi-root "$partitions"|cut -d: -f2)
swappart=$(grep obi-swap "$partitions"|cut -d: -f2)
With
while read LINE || [ "$LINE" ]
do
case $LINE in
obi-root:*)rootpart="${LINE/*:}";;
obi-swap:*)swappart="${LINE/*:}";;
*);;
esac
done < "$partitions"
which only uses read (1 program for both)
I have tested with the target drive connected internally and
externally. It makes no difference in this case. I would say that this
is a show-stopper. I don't think we should abandon selection of
partitions via the zenity menus. It is awkward to use gparted for the
selection, when there is no [other] editing of partitions.
Fully agree
2. Already existing operating systems in internal drives (including
eSATA), but not in USB drives, are recognized and added to the grub
menu. This problem remains, but we can live with it. (It is no
show-stopper.)
I might try to get this working better... but for now if you try 229 and
things work we can sigh a big sigh of relief
This has been a fun experience learning what OBI does and converting it
to use zenity.. quite a neat bit of work involved!
But, I think we are getting closer to the finish line!! A few more days
until May... hopefully we can get the last bits in place.
As long as no show stoppers exist we can release and I can test on the
unstable branch more.
--
Regards
