dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

Do we really need to require that each patch is accompanied by a unit
test? It seems overkill in this case but I agree it would be good to
have.

Something that we do need though is a signature on the following two forms:

  http://fenicsproject.org/pub/copyright/forms/

So that we know we may actually include the code in DOLFIN.

--
Anders


On Wed, Apr 06, 2011 at 03:59:21PM +0200, Neilen Marais wrote:
> Hi Johan,
>
> On Mon, Mar 28, 2011 at 5:35 PM, Johan Hake <johan.hake@xxxxxxxxx> wrote:
> >
> > On Monday March 28 2011 01:12:54 Neilen Marais wrote:
> > > Hi Johan,
> > >
> > > > Thanks for your patch! Is it possible for you to construct a unit test
> > > > for this converter? There is already one in:
> > > >
> > > >  test/unit/meshconverter/python/test.py
> > > >
> > > > for abaqus mesh. So I guess it should be straight forward to implement
> > > > one for gmsh too.
> > >
> > > Yes, I could do that. Probably tomorrow or so. Will keep you posted :)
> >
> > Thanks Neilen!
> >
> > This is very helpful for us!
> >
>
> Hi,
>
> Sorry for the delay, I came down with a particularly nasty flu last
> Monday and have only fairly recently rejoined the living :) Am I
> correct that in order to run the unit tests I first need to make a
> working dolfin build from the bzr repository?
>
> I don't seem to get very far with this process. Would I need to
> install all the FEniCS components from bzr? I'm running an Ubuntu
> Maverick x86_64 machine, any hints/pointers on how to do this?
>
> Thanks
> Neilen
>
>
> >
> > Johan
> >
> > > Regards
> > > Neilen
> > >
> > > > Johan
> > > >
> > > >>
> > > >> _______________________________________________
> > > >> Mailing list: https://launchpad.net/~dolfin
> > > >> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> > > >> Unsubscribe : https://launchpad.net/~dolfin
> > > >> More help   : https://help.launchpad.net/ListHelp
> > >
> > > _______________________________________________
> > > Mailing list: https://launchpad.net/~dolfin
> > > Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> > > Unsubscribe : https://launchpad.net/~dolfin
> > > More help   : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dolfin
> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dolfin
> More help   : https://help.launchpad.net/ListHelp