kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@...>]

jean-pierre.charras@... wrote:
> Guys, how about this:
> 
> 1 - Until now zoom levels were 1, 2 ... 2048.
> 2 - many user want intermediate values.
> 3 - Wayne enhanced the zoom code to allow these intermediate levels.
> 4 - A kicad release candidate is coming soon, ans doc update, the best 
> is do not make large changes about zoom.
> 
> So (before having a better way to handle zoom level, like user selection 
> values, or zoom step adjust) a reasonnable way is :
> use the old values and add an intermediate value (something like 1, 1.5, 
> 2, 3, 4 , 6, 8...in old values, and in new values: 10, 15, .. 20480)
> Because i had a *lot* of problems due to integers overflows in graphic 
> libraries, no zoom less than 1 (or 10 in new values),
> because i am afraid these problems still exists in 2009.
> 
> After the stable version, a better way to handle zoom values can be 
> tried, tested and refined.
> But for now, I am thinking last changes commited were not refined or 
> fully tested.
> As an example, last updates made changes zoom level values, but they 
> were not fully tested ( and commited some days before the next release)
> because the popup menu does not show all values, and therefore the 
> user cannot select all zoom values. This is not very good (and could be 
> sound like a bug).

This is not a bug. This is by design. The goal was to prevent the zoom
popup submenu from becoming too large. I actually think fifteen entries
is too many but I saw this situation coming so I made it as large as I
thought was reasonable. If you want to add more zoom values to the zoom
submenu, in the header file id.h change the number 15 in the line

ID_POPUP_ZOOM_LEVEL_END = ID_POPUP_ZOOM_LEVEL_START + 15,

to however many zoom levels you want to display in the popup menu.

Wayne

> and if there are to much values this popup could be unuseable (too 
> big to be seen on screen).
> This means zoom levels list choice is not just a matter of choice 
> of values, its *does* involve more work.
> 
> Please, excuse my poor english.
> 
>