← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Ortographic mode for 3D viewer and minor cleanup


On Oct 7, 2010, at 17:54 PM, Alex G wrote:

> Hash: SHA1
> On 10/07/2010 05:03 PM, Dick Hollenbeck wrote:
>> We'd like to see you contribute more.
>> On the enums' commas, I usually leave them in there with the notion that
>> you will be adding more and, why waist the time to go back and add that
>> comma to extend the list?
>> The language designers thought the same thing after a point.  This was
>> not originally in the language and they it added after somebody asked
>> for it.
>> So now comes the compiler developer, who probably does not have as much
>> experience as the language designer, and ties that warning to a
>> -pedantic flag.  That is fine, since he also gave you the ability to
>> turn off warnings on a case by case basis, which what I would suggest
>> you do.  (Whatever way you are controlling the compiler flags.  I just
>> let the cmake script do that for me.)
>> It is part of the language, and many experienced programmers utilize it,
>> and any compiler supporting C++ should handle it without voicing an
>> opinion on it if asked to be quiet about it.
> Your point is well made. I'll look into silencing gcc about this
> specific issue, and I won't make noise about this in the future.
>> And I cannot believe I actually spent all the time to write this.
>> But getting you to contribute more is worth it.  Keep up the good work!
> Thank you for taking the time to explain this. I will write a few lines
> to be added to the coding policy detailing this issue, and how to
> silence it in gcc (once I fugure out how it's done -- don't tell me, it
> will be an interesting $ man gcc excercise for me).

Sorry, next time I will read all email before responding

> I'm looking forward to making more contributions, and I'll be able to do
> more as I tackle more parts of kicad and get familiar with the code.
> What I'd like to see is OpenGL rendering in pcbnew, so that's what I'll
> try to familiarize myself with next. The possibilities are endless.
> BTW, It was an old comment of yours directed to me that convinced me to
> download the kicad sources for the first time. :)
> Alex
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
> WaFcJIPsTKEen6U/EXUQprqHGuPT9XdiOdNsyio0i1+nx4p1uuXo6JWUfOLW3gUF
> HO+r/ky/6OMb1Pimz24aK9RbEyXAOgXdkxYlaGdUPcsL+GPJIs1Zi2aPYaqVClS4
> 8incAeU5A9OdyDJnHKi78bJnsrS05ujErWdkVoOleWtkHFhaYJj530263SB9et03
> HTqDFSOWT0rYfc74sOfkaCdJoD8xROK+JbRTHby/tU1CFGDsqpCr7zzLhar6rSlM
> zbBfgkLPBh+qmUf9anNljKcmHUbGn8hPmNGUC0bayWfn/ThOGh6RmNUzmKKpG2fC
> vCxQusrwSVX+nlrz3Qqkji+pNHDf994pNIhQxbU2H1NUAhYt/7LROsRF1zN7eN9N
> kU9CJhIWjtAVZta0JE/YllLiSa7fyiZE4EG5MH0cWOltoWUQs2r47tTVX5sa9nBJ
> +1TQduuGidoqggFSjqDl8tYKY4wFov56tY+z9fJt9bJanA84d7AFJLbR7w//9tDT
> noqpUikKmCAZiF8SZSaCmtSIbMYsX3gLNlicFhEikAG7/ruOeT+dVQaZqf4hZdWV
> As07u14yxN0k3fUVRSP1
> =g8qx
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp