← Back to team overview

kicad-developers team mailing list archive

Re: 3D-Viewer - Request for merge evaluation

 

Ok, I just wanted to know if I had to update wx for the windows builds.

2016-06-24 12:31 GMT+02:00 Collin Anderson <metacollin@xxxxxxxxxxxx>:
> Antialiasing is not dependent on wx.  wx doesn't actually need to support or not support it.  The bug in question is that wx doesn't really ask the driver if multisampling (antialiasing) is supported the way windows wants, so it incorrectly repots that it doesn't work.
>
> However, antialiasing/multisampling is entirely the domain of the driver.  Many drivers (at least windows one, such as if you install Catalyst Control Center in windows for example) allow you to override applications that ask for a nonmultisampled context.  Basically, wx takes what the driver gives it (as does everything else) so if the context is multisampled, it is multisampled.  It's not something wx really has the option of supporting or not supporting.  In this case, only the check to see if it is supported is broken.
>
> That said, virtually every driver that supports MSAA (multisample anti-aliasing) also has it turned on by default.  Honestly, just letting the driver give the context it gives is a perfectly valid solution.  Often, there will only be code that is there specifically to turn MSAA off (for performance, if needed) but it won't ever be explicitly turned on.
> --
> "Violence is the last refuge of the incompetent." - Isaac Asimov
>
>> On Jun 24, 2016, at 3:43 AM, Mário Luzeiro <mrluzeiro@xxxxx> wrote:
>>
>>> What version of wx is required to make anti-aliasing work on windows?
>>
>>>> I found that (anti-aliasing) was an issue on wxGLCanvas (see wxMSW FIXES):
>>>> http://trac.wxwidgets.org/ticket/16909
>>
>> Hi Nick,
>>
>> I don't know, I have no knowledge to follow that ticket in the link and see where it was applied.
>> Anyway, as I explain on my last email to JP, I changed the source code so I hope that your GPU driver will able to decide what is best, or you can force it to use max quality.
>> I tested on my 2 windows machines and it works for me. == anti-aliasing is working (provide that I set it on the GPU driver configurations)
>>
>> Mario
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>


References