kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

Wayne,

I attach a patch updating the UI policy. I would rather you commit the
patch, to be sure you agree with the changes.

Regards,
Orson

On 09/03/2016 02:17 AM, Wayne Stambaugh wrote:
> We've been dancing around this issue for a while without any real
> resolution.  I'm fine with using Mark's version of wxFB but a lot folks
> are going to want to use whatever is packaged for their distro rather
> than build wxFB from source which presents a serious issue.  I'm not
> sure there is a good answer for this problem.  If no one else has any
> objections, I'm willing to make Mark's wxFB fork the official version
> for KiCad dialog submission for the time being.  In the long run, if
> wxFB is not actively being developed, I would rather come up with an
> alternative.
> 
> FWIW, I think most of you know how I feel about dialog creation tools
> vs. creating them programmatically.  Kicad's dialogs used to be created
> this way but I got out voted at the time the decision was made to switch
> to wxFB.  I'm feeling better about my choice all the time. ;)
> 
> On 9/2/2016 7:11 PM, Chris Pavlina wrote:
>> I would vote in favor of using Mark's fork officially for everyone, if
>> it builds okay on all the platforms. wxfb is kinda nasty, if we're going
>> to use it it's nice to have our own fork that solves at least a few of
>> these issues.
>>
>> On Sat, Sep 03, 2016 at 08:45:12AM +1000, Cirilo Bernardo wrote:
>>> I just use MRoszko's fork; it's cleaner than the original and much
>>> easier to configure and build since the bizarre wxFB build system
>>> had been eradicated and replaced by CMake.
>>>
>>> git clone https://github.com/marekr/wxFormBuilder.git wxfb
>>> cd wxfb && git checkout wxFB3.5-1
>>>
>>> A half year or so ago I tried the later wxFB in development but it
>>> broke so many things that I just reverted the files and went back to
>>> wxFB3,5-1.
>>>
>>> - Cirilo
>>>
>>>
>>> On Sat, Sep 3, 2016 at 7:28 AM, Chris Pavlina <pavlina.chris@xxxxxxxxx>
>>> wrote:
>>>
>>>> Along these lines: this isn't the first time wxfb version issues have
>>>> come up. Perhaps we should pick an "official" wxfb version for the
>>>> project to use, and then actually provide builds of it for developer use
>>>> (as it can be a bit annoying to track down a specific version)? Then we
>>>> can upgrade together as new versions come out.
>>>>
>>>>
>>>> On Sat, Sep 03, 2016 at 09:16:41AM +1200, Simon Wells wrote:
>>>>> dialog_pad_properties_base.fbp h cpp was last modified in commit
>>>>>
>>>>> 63decd70e6ab1bf2fe95db3f426f6cdfc79be213
>>>>> https://git.launchpad.net/kicad/commit/?id=
>>>> 63decd70e6ab1bf2fe95db3f426f6cdfc79be213
>>>>>
>>>>> the problem is this version of wxformbuilder is newer than the one
>>>>> available on sourceforge and it is very difficult to build on other
>>>>> platforms ( i tried a while ago and gave up as it had issues)
>>>>>
>>>>> the version that was used to save these files has broken it on older
>>>>> versions of wxformbuilder
>>>>>
>>>>> Is there a version of wxformbuilder that we should be using to avoid
>>>>> it breaking on other versions?
>>>>>
>>>>> the last available from sf.net is 3.5rc1 iirc
>>>>>
>>>>> thanks
>>>>>
>>>>> Simon

From 1572c5e69a11f4dff74901c5f4eb323a8fff6cf3 Mon Sep 17 00:00:00 2001
From: Maciej Suminski <maciej.suminski@xxxxxxx>
Date: Wed, 7 Sep 2016 13:59:58 +0200
Subject: [PATCH] UI policy update

Added a note about Mark's wxFormBuilder repository and
'internationalize' checkbox in wxFB.
---
 Documentation/development/ui-policy.md | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/Documentation/development/ui-policy.md b/Documentation/development/ui-policy.md
index 8fe0be5..a938790 100644
--- a/Documentation/development/ui-policy.md
+++ b/Documentation/development/ui-policy.md
@@ -72,9 +72,11 @@ Webpage titles and navigational elements | Header
 This section defines how dialog boxes should be designed.  The KiCad project
 uses the [GNOME User Interface Guidelines][gnome-ui-guidelines] for laying out
 dialogs.  KiCad's dialogs must be designed with [wxFormBuilder][wxformbuilder].
-Please use the most recent version of wxFormBuilder possible to prevent version
-issues with other developers.  When designing dialogs, follow the [visual layout
-section of the GNOME User Interface Guidelines][gnome-ui-layout].
+As wxFormBuilder available in packages is likely to be a different version than
+what other developers have installed, it has been decided to use the version
+kept in a Github repository, branch [wxFB3.5RC-1][wxformbuilder-github] to avoid
+version mismatch.  When designing dialogs, follow the [visual layout section of
+the GNOME User Interface Guidelines][gnome-ui-layout].
 
 ## Escape Key Termination ## {#dialogs-esc-key}
 Please note that the escape key termination only works properly if there is a
@@ -147,6 +149,12 @@ broken.  Do not implement default button handlers in your dialog code.  Use
 validators to transfer data to and from controls and allow the default dialog
 button handlers work the way they were designed.
 
+## Internationalization ## {#dialog-i18n}
+
+To generate a list of strings occurring in a dialog, one needs to enable
+'internationalize' checkbox in the project properties.  Otherwise, it will not
+be possible to translate the dialog.
+
 # String Quoting # {#quoting}
 Often text strings will be quoted for display which use may used in controls
 that render HTML.  Using angle brackets will cause grief for HTML rendering
@@ -161,6 +169,7 @@ controls so text should be quoted with single quotes ''.  e.g.:
 [gnome-ui-layout]:https://developer.gnome.org/hig/stable/visual-layout.html.en
 [gnome-ui-style]:https://developer.gnome.org/hig/stable/writing-style.html.en
 [wxformbuilder]:https://sourceforge.net/projects/wxformbuilder/
+[wxformbuilder-github]:https://github.com/marekr/wxFormBuilder/tree/wxFB3.5-RC1
 [wxwidgets-doc]:http://docs.wxwidgets.org/3.0/
 [wxdialog-setescapeid]:http://docs.wxwidgets.org/3.0/classwx_dialog.html#a585869988e308f549128a6a065f387c6
 [wxwidgets-sizers]:http://docs.wxwidgets.org/3.0/overview_sizer.html
-- 
2.9.2

Attachment: signature.asc
Description: OpenPGP digital signature