kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Kasper,

I just pushed the fix for this.  Please test it and let me know if you
find any issues.  Keep in mind that this only effects the library
nicknames.  The '/' character will still be illegal for symbol and
footprint names.

Thanks,

Wayne

On 6/19/2018 4:04 PM, Kaspar Emanuel wrote:
> Thanks Wayne, this will save me (and anyone else using
> monostable/kicad_footprints
> <https://github.com/monostable/kicad_footprints#readme>) quite a bit of
> time!
> 
> ​
> 
> On 19 June 2018 at 19:13, Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     I took a second look at this and you are correct.  The library table
>     nickname character filter was changed to include the library item
>     (symbol or footprint) name characters which is incorrect.  The valid
>     library nickname characters are different from the valid library item
>     name characters.  I will fix this as soon as I get a chance.
> 
>     On 6/13/2018 4:59 PM, Kaspar Emanuel wrote:
>     > Those are good reasons for not allowing slashes in the footprint names
>     > but I don’t see any reason for not allowing them in /library/ nick
>     > names. As far as I can tell any character except |:| could be allowed
>     > before the |:|. It’s a pretty long standing “bug” so we could view it as
>     > standard. It will break "compatibility" with fp-lib-tables that use the
>     > slash character and users were never warned about using it.
>     > 
>     > If it /will/ be allowed in v6 why make people change it when going
>     from
>     > v4 to v5?
>     > 
>     > ​
>     > 
>     > On 13 June 2018 at 18:35, Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>     > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>> wrote:
>     > 
>     >     AFAIK you cannot use slashes ('/') or colons (':') in either a library
>     >     (footprint or symbol) table nickname or a footprint or symbol name.  If
>     >     you could use a slash in a footprint library nickname in the past, this
>     >     was a bug and the fact that it worked was a fluke.  The reason is that
>     >     the library ID format is NICKNAME:FP_OR_SYM_NAME/REV.  The other issue
>     >     is that footprint names are actually the filename sans extension.  Using
>     >     a slash in a footprint name would render it unusable.  I am going to fix
>     >     this as part of the new schematic and symbol library file format v6
>     >     work.  The reason this was not done for v5 the fix will require
>     >     schematic, board, and footprint file format changes which I didn't not
>     >     want to do for v5 as we were already late into the development cycle.
>     > 
>     >     On 6/13/2018 2:19 PM, Kaspar Emanuel wrote:
>     >     > Sorry to bring this up again but it just strikes me as a bit odd. Can we
>     >     > not allow slash characters in the fp-lib-table as before and not break
>     >     > backwards compatibility? It seems to read fp-lib-tables with slashes
>     >     > fine but current KiCad nightly won't let me edit it. I am up for making
>     >     > a patch if there's a chance it could make it into v5.
>     >     > 
>     >     > 
>     >     > On 10 May 2018 at 12:07, Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
>     >     > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>> wrote:
>     >     >
>     >     >     On 5/8/2018 6:27 PM, Kaspar Emanuel wrote:
>     >     >     > I see, thanks for the info Wayne. So enforcing this
>     for names in
>     >     >     > _footprint_ lib-tables is simply done for code sharing?
>     >     >     >
>     >     >     > If I understand you correctly short-lived means for
>     the lifetime of v5?
>     >     >
>     >     >     This is correct.  The plan is to fix this after the new
>     schematic file
>     >     >     formats are implemented so it should happen some time
>     during v6
>     >     >     development.
>     >     >
>     >     >     >
>     >     >     > On 8 May 2018 at 22:10, Wayne Stambaugh
>     <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
>     >     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>
>     >     >     > <mailto:stambaughw@xxxxxxxxx
>     <mailto:stambaughw@xxxxxxxxx> <mailto:stambaughw@xxxxxxxxx
>     <mailto:stambaughw@xxxxxxxxx>>
>     >     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>>> wrote:
>     >     >     >
>     >     >     >     This was done because the schematic file format parser
>     >     would break
>     >     >     >     with the forward slash character.  I hope to fix this
>     >     early in the
>     >     >     >     v6 development but it's a pain we are going to have to
>     >     live with
>     >     >     >     until the new schematic file format is complete. 
>     I wish
>     >     I had the
>     >     >     >     time to do it all at once but it's just wasn't in the
>     >     cards. 
>     >     >     I have
>     >     >     >     to implement this one piece at a time.  There was an
>     >     >     announcement on
>     >     >     >     this mailing list about it.  I apologize for the
>     >     inconvenience. 
>     >     >     >     Hopefully it will be short lived.
>     >     >     >
>     >     >     >     Cheers,
>     >     >     >
>     >     >     >     Wayne
>     >     >     >
>     >     >     >     On 05/08/2018 04:40 PM, Kaspar Emanuel wrote:
>     >     >     >
>     >     >     >         Hi,
>     >     >     >
>     >     >     >         looks like a forward slash character in nick names
>     >     in the
>     >     >     >         fp-lib-table is not supported any more (it can be
>     >     read but it
>     >     >     >         cannot be saved).
>     >     >     >
>     >     >     >         This breaks compatibility with older fp-lib-tables
>     >     somewhat. I
>     >     >     >         have been using slashes in names to namespace
>     >     fp-lib-tables
>     >     >     >         created for my footprint collection
>     >     >     >       
>      <https://github.com/monostable/kicad_footprints
>     <https://github.com/monostable/kicad_footprints>
>     >     <https://github.com/monostable/kicad_footprints
>     <https://github.com/monostable/kicad_footprints>>
>     >     >     <https://github.com/monostable/kicad_footprints
>     <https://github.com/monostable/kicad_footprints>
>     >     <https://github.com/monostable/kicad_footprints
>     <https://github.com/monostable/kicad_footprints>>>
>     >     >     >       
>      <https://github.com/monostable/kicad_footprints
>     <https://github.com/monostable/kicad_footprints>
>     >     <https://github.com/monostable/kicad_footprints
>     <https://github.com/monostable/kicad_footprints>>
>     >     >     <https://github.com/monostable/kicad_footprints
>     <https://github.com/monostable/kicad_footprints>
>     >     <https://github.com/monostable/kicad_footprints
>     <https://github.com/monostable/kicad_footprints>>>>>.
>     >     >     >
>     >     >     >         Is there a good reason for not allowing slashes in
>     >     names?
>     >     >     >
>     >     >     >         Cheers,
>     >     >     >
>     >     >     >         Kaspar
>     >     >     >
>     >     >     >         ​
>     >     >     >
>     >     >     >
>     >     >     >         _______________________________________________
>     >     >     >         Mailing list:
>     >     https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>
>     >     >     >         <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>>
>     >     >     >         Post to     :
>     kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
>     >     >     >         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>>
>     >     >     >         Unsubscribe :
>     https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>
>     >     >     >         <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>>
>     >     >     >         More help   :
>     https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>>
>     >     >     >         <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>>>
>     >     >     >
>     >     >     >
>     >     >     >     _______________________________________________
>     >     >     >     Mailing list:
>     https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>
>     >     >     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>>
>     >     >     >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
>     >     >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>>
>     >     >     >     Unsubscribe :
>     https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>
>     >     >     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>>
>     >     >     >     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>>
>     >     >     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>>>
>     >     >     >
>     >     >     >
>     >     >
>     >     >
>     >
>     >
> 
>