kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #40288
Re: Improving library editor checks
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Thu, 25 Apr 2019 10:15:31 -0400
-
Autocrypt:
addr=stambaughw@xxxxxxxxx; prefer-encrypt=mutual; keydata= mQGiBEM0hxQRBAC2fNh3YOVLu1d5GZ0SbrTNldGiGnCJPLqzEnqFX9v6jmf33TMt6EmSLkl6 Wtfkoj0nVwKxcYmJkA8DX0QAokBkwNIzhSsBzQvthBLIk/5LnPVVKrEXOcL4mUyH1doKlkaE slgJozNa6Av+oavcvD02o1zJOloBbaHlNlyRt7fKswCgtIFlVjWggVH/15KfWk+Qo5JVPbME AIUBAQyL2OAx0n60AWec2WHnO9buHuG0ibtICgUMkE+2MRmYyKwYRdyVwGoIUemFuOyHp0AJ InX4T+vy2E7vkwODqjtMLfIoRkokW74Fi4nrvjlhOAw/vdq/twLbAmR9MOfPTpR4y7kQy1O2 /n+RkkRvh26vTzfbQmrH7cBJhk6aA/9Uwvu3E4zNJgHVZeS0HyWtmR1eOPPRbnkPgJTToX5O KMKzTJI/FX6kT7cFoCamitHrW3BJP4Dx+cMMsa47EGxqVTdbVJ4LjogsXTXxb+0Fn1u4zBdx x3Cer6O7+hqWy7zvpzeC6nSREjqDKa5CgHtv/GLm5uFPOmsjAsnHj2tlBrQmV2F5bmUgU3Rh bWJhdWdoIDxzdGFtYmF1Z2h3QGdtYWlsLmNvbT6IeAQTEQIAOBYhBOffs6CbblRzBkv33BtR cWlZ+CReBQJbFBS2AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEBtRcWlZ+CReMI8A nRbrLkzp7+c2f0vX7sfg4ICX8LAKAJ9uClo4uJajmZa5zZrL2nKdZlUwIrkCDQRDNIcxEAgA gCru+3/aOC6RCjpvYC72wY+d5SmHphC6yeiV2/mOumyt5MLo/Ps2GznZr11JspqFk5K/Zpvp MMLqqjDZ39+50a2iKRQFJ6NlK+hJWMmj6eJygQrCwYo3Gjc6CqfrqUv+8VSnf/i5sIZmtOVA 4ZjML18MuBvMSsNdVLFJd5HNnYb1iOECpvqdPVh/21LLCEw7MUUGGnHBhCrmk2aJe5hFmcSN g4ldBcXrgMQBwf7aMVoobXBMFDb/IENByXn0llB7Gr2IFMRmNS9/p8s/II1Yl2bTqyX4FSz8 cfn7C9KEz7faZ7wzAcpwHFC/zs3JoAjJ0IEKdNUpIwAlKMzT3CzctwADBQf/cxpG28MKyrqk nNmq/8LQLy+x6FSYXBLjxQz9BiBNYeesDZQ6J5UbL1mjpJzMa5tLZypPYo4bbGyR22hrbyDF K7m6AcVaMIJKl98g4ukMutFfAJyRDaREH5Zl/X1P4u1Z/yaAIy9mKaNbaK1/5djNJ5wCTFen TUgAp9xdc30kGkFDdLJFp5uxDY4P0vaZiZdjUCvDM3Zjv5IzpNOfxVqTUBQNUP/BnnKhkk0p DTD6s3X8S+D0rOtEBQ8K0cwERI/E8EFa8nj0TNw4e2MYGR8wg+SxqJ7z5f0zPY0bO6G9DDFB wYCqzzPWGqdAh9vA5971TAbPERtdFybhkurozp2SfYhJBBgRAgAJBQJDNIcxAhsMAAoJEBtR cWlZ+CResHUAniULLCWiT26ieRTl7N2vS6vBo/DuAJ4m7Ss/gyiW6ybTn1ctDXAUgm2QVQ==
-
In-reply-to:
<CALAp9RF9Muo-xYp6hatf5LhsSxCnMK7PBnPGNuUCc3cFeq2-4Q@mail.gmail.com>
-
Openpgp:
preference=signencrypt
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1
Python scripting support is hopefully going to be implemented at some
point during V6 development. This should allow you to integrate the KLC
scripts directly into the symbol library editor. This will most likely
happen late in V6 development because there are some major functional
changes to the low level schematic and library objects. It doesn't make
sense to swig this until the low level object APIs stabilize.
On 4/25/19 9:39 AM, Antonio Vázquez Blanco wrote:
> From the feedback given I am thinking about changing the proposal.
>
> Given that my ultimate goal was to integrate KLC check into KiCad to
> improve the quality of contributions and reduce librarian work, and that
> seems conflicting we may need to re-think my approach to the problem.
>
> I don't want to enforce KLC on every user. Furthermore, from your
> comments I thought that maybe I am interested in even writing some tests
> that would conform with a set of rules that only my organization would
> care about. That being said, I came to the conclusion that maybe we
> could define groups of tests that could be enabled or disabled depending
> on user preferences. For example, KLC could be one of those groups of rules.
>
> John suggested the usage of external scripts. That could be the solution
> to various problems. Scripts could be externally updated if needed and
> they would also allow to users to write their own checks without having
> to recompille the full source code. It would also allow the distribution
> of those "groups" of rules suggested above.
>
> Maybe we sould think of a interface that would allow KiCad to look for a
> set of Python scripts inside a particular folder to allow us to perform
> a certain set of checks that would return result objects that KiCad
> could later show.
>
> Is this approach better? If so, given my lack of knowledge about KiCad
> codebase, I would need some help designing that interface.
>
> Thank you for your feedback!
>
>
>
>
>
>
> El jue., 25 abr. 2019 a las 13:46, Wayne Stambaugh
> (<stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>) escribió:
>
> Antonio,
>
> Exactly what checks are you planning on implementing? As long as they
> are generic in nature like off grid pin checking, then I'm fine with
> that. If they are specific KLC checks like spacing, line width, etc,
> that is a different issue. We should not be forcing KLC rules on all
> users. If you wanted to make KLC style checks that can be customized
> and disabled to meet each users specific needs, I would be open to that.
>
> This code is not in the ERC code. Symbol library tests are separate
> from the ERC and live in the symbol editor code. You can find the
> symbol library editor code in the ./eeschema/libedit folder in the
> source tree.
>
> Thank you in your interest in contributing to KiCad.
>
> Cheers,
>
> Wayne
>
> On 4/25/19 5:39 AM, Antonio Vázquez Blanco wrote:
> > I've been playing around a little bit with KiCad source code
> lately and
> > in the forums [1] I was encouraged to write to the dev mailing list in
> > order to get feedback on how to improve the current library error
> checking.
> >
> > Summarizing the thread, I made some changes [2] so that a couple
> of KLC
> > checks are performed on syms but now that I've done that I would
> like to
> > implement this properly. I am looking for pointers on how should I
> > implement this so that the chances of me getting the code upstream
> > maximize and so that I can reuse the ERC/DRC code as much as possible.
> >
> > Thank you!
> >
> > [1] https://forum.kicad.info/t/improving-library-editor-checks/16557/5
> > [2]
> >
> https://gitlab.com/kicad-mirror/kicad-source-mirror/compare/master...feature%2Fklc
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References