launchpad-dev team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

On Sep 9, 2009, at 19:03 , Karl Fogel wrote:

> Christian Robottom Reis <kiko@xxxxxxxxxxxxx> writes:
> > They can get pretty noisy, yeah -- but I think the main issue is that
> > noise from the conversations in #launchpad-dev can bleed over the
> > reviews happening on #launchpad-reviews, and OCR is meant to be  
> > focused
> > and fast. That's my impression at least -- at any rate, the fact that
> > you don't know about #launchpad-reviews may point to us not marketing
> > that channel properly?

If someone turns up in #launchpad-dev asking about getting code review  
he will very quickly get pointed to #launchpad-reviews.

> The situation is worse than that: I knew about the channel and then
> *forgot* about it, because nothing ever happened to pull me into it.

Right, but you would've found out the first time you wanted to submit  
a branch for review.

> That's how it's going to be for everyone.  Sure, we might hear about
> this other channel over there, but we'll forget about it, and  
> meanwhile
> all this important code-related activity will be happening off  
> somewhere
> where most devs don't see it...
>
> My guess is most people who use IRC know how to ignore the chatter
> around them, when they're focused on a particular conversation.  Do we
> have evidence or experience to suggest that doing reviews in the dev
> channel was a real problem?  If we don't, I'd really like to try  
> merging
> it back into #launchpad-dev and seeing what happens.

I'm -1 on combining the two channels.  For one, we use the topic very  
actively to reflect who is reviewing, what's being reviewed at the  
time, and the outstanding queue.  Looking just now at the topic for  
#launchpad-dev I see three lines of text.  Adding a fourth that  
changes 3-4 times/hour is not going to work.

Besides, I just submitted an RT today to get #launchpad-reviews logged…

--bac