openerp-community team mailing list archive
-
openerp-community team
-
Mailing list archive
-
Message #06975
Re: Suggestion for OCA conventions
On 20-10-14 16:52, Sandy Carter wrote:
> What the consensus I seem to get out of this is: Often it is better to
> separate the models (especially in xml), but there are some acceptable
> exceptions:
>
> * Small changes to models
> * One to many relationships (single column add to related model)
> * At some point, a small change becomes to big and the file must be split.
> * All changes are very closely related to a same feature
> * Wizards
> * Connectors (I'm adding this one)
>
> No one seemed to object to naming the Class, .py file and xml files
> according to the model (or largest model in the case of filenames).
>
> Is this something we can agree on?
Thanks for writing such a clear motivation! I support your proposal, as
long as refactorings along these lines will not be demanded in reviews
of small bug fixing pull requests in legacy modules.
Follow ups
References
-
Suggestion for OCA conventions
From: Sandy Carter, 2014-10-17
-
Re: Suggestion for OCA conventions
From: David Beal, 2014-10-17
-
Re: Suggestion for OCA conventions
From: Sandy Carter, 2014-10-17
-
Re: Suggestion for OCA conventions
From: Pedro Manuel Baeza Romero, 2014-10-18
-
Re: Suggestion for OCA conventions
From: Daniel Reis, 2014-10-19
-
Re: Suggestion for OCA conventions
From: Sylvain LE GAL, 2014-10-19
-
Re: Suggestion for OCA conventions
From: Graeme Gellatly, 2014-10-19
-
Re: Suggestion for OCA conventions
From: Guewen Baconnier, 2014-10-20
-
Re: Suggestion for OCA conventions
From: Leonardo Pistone, 2014-10-20
-
Re: Suggestion for OCA conventions
From: Sandy Carter, 2014-10-20