← Back to team overview

qpdfview team mailing list archive

Re: Fwd: Re: Various issues

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Thanks for testing!

On 23.06.2012 22:21, Andi Șerbănescu wrote:
>> Would be nice if you could test this in both versions and check
>> that you never get an active scroll bar when fitting
> 
> I checked out both trunk and future with different documents and
> view settings; it didn't activate any horizontal scroll-bar. The
> left outer border is 1 pixel wider, though.

Yes this is to be expected, e.g. if the scene goes from -105.5 to
105.5 then the scrollable area becomes -105 to 106 after rounding.
We'll probably have to live with that. (But the future branch should
center correctly even if the page sizes are not uniform.)

>> By the way: Do get tool bar icons in the future branch?
> 
> The vast majority of buttons have text captions, so no. Only 1/2
> pages and fit width/height have icons, I think.
> 

Ok, so this tell us: Loading SVG icons from resources or files
definitely works, but neither QIcon::hasThemeIcon nor QIcon::fromTheme
do their job. I did attach a simple test program which should give you
some useful information on where Qt tries to find the icons and which
tries to display the "document-open" icon at 24x24...

Best regards, Adam.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJP5itqAAoJEPSSjE3STU34SxUH/Ag4xNj9x0BuRHY5ZKkPkGR2
nFl+53x1jcRfUbIDvQxlmN+JWT5pOTeXXjHCUdYLOnR03s/WYBsrAOJZah3jMTLa
Fpr0q0uHjGsGj4LXrjX1HUPDfdNHIBNlaeg/kXVDfvz2QwiHAog8FdylTjr0FCFA
p7ybJnjyqppun6YKshcB9rIj4Jm9RmwPnmiGZ2DFQampwhBBsXsXLcOOxViresm0
uNLA1V3RRxHdubb5JMmNbPVyUF+ro9YbovApXWDLQV4hemovFgdCdGcXykaift7a
4vsavuhkVdjY7IXtHQ2r9FxsGYrBnxRiMNSG6i9nNnQWIFzStG2MNxshjk8BXl0=
=HN5I
-----END PGP SIGNATURE-----
QT += core gui

TARGET = fromThemeTest
TEMPLATE = app

SOURCES += main.cpp
#include <QtCore>
#include <QtGui>

int main(int argc, char *argv[])
{
    QApplication a(argc, argv);

    qDebug() << "themeSearchPaths:" << QIcon::themeSearchPaths();
    qDebug() << "themeName:" << QIcon::themeName();

    qDebug() << "hasThemeIcon(\"document-open\"):" << QIcon::hasThemeIcon("document-open");

    QLabel l;
    l.setPixmap(QIcon::fromTheme("document-open").pixmap(24,24));
    l.show();
    
    return a.exec();
}

Follow ups

References