| Thread Previous • Date Previous • Date Next • Thread Next |
Justas, I made another commit for propagating roster changes to linked sections that come after the section in time, as per Tom's request. Please review that diff along with the other ones for the upcoming meeting. Tom, I changed the extend_term view's confirmation message to be a sentence and changed the header labels in the other views to use h2. I attached some more screenshots. I didn't change the unlink_section confirmation message to be a sentence because the section could be linked to both a previous and a next term. That would make the sentence complicated, so I left it as is. If you have any suggestions for sentences for both the unlink from one section case and the unlink from two sections case, let me know. Thanks, Alan On Fri, Apr 15, 2011 at 3:57 PM, Alan Elkner <aelkner@xxxxxxxxx> wrote: > Tom, > > I didn't use a sentence because I was struggling with punctuation, > mostly commas, when one says, for example, "in term, Term1, for > course, Math.' I believe it is the convention in English to use the > commas like that, but then again, I'm not an expert. Anyway, other > languages may have different conventions, commas or not, so what can > one do to create strings that are translatable and still make sense > when broken up and put back together. I guess I can solve this by > creating the message string in python, using a translatable format > string. I was just trying to do more in the page template as Justas > had suggested, but page templates don't have translatable format > strings. I'll just do it in python. > > As for the last question, if the user hits Link without selecting a > section, they probably just forgot to. It's better to have an error > message than to come back to the same view as if nothing happened. > Also, if we were to return to the section linkage view without > complaint, that may mislead the user into thinking something happened. > I know, nothing will have changed, but an absent-minded user may > think they did something. I don't know, it's you call. > > -Alan > > On Fri, Apr 15, 2011 at 2:31 PM, Tom Hoffman <tom.hoffman@xxxxxxxxx> wrote: >> Alan, >> >> Looks pretty good over all. >> >> When you have Course: Year: etc. at the top, that should be >> highlighted to some extent. Probably a h2 or h3 as shown in the >> guidelines. >> >> The confirmation screens you can just plug the relevant values into >> the sentence, like >> >> Click "Extend" to create a linked section in term "first" containing >> the students and instructors from Math 1 term "third." >> >> What happens if I don't select a section before clicking "link" in the >> last one? What would the user expect to happen? >> >> --Tom >> >> On Fri, Apr 15, 2011 at 12:39 AM, Alan Elkner <aelkner@xxxxxxxxx> wrote: >>> Hey Guys, >>> >>> I attached some more screenshots reflecting the changes I made to the >>> section_linkage.html view as well as the three new views, two for >>> confirmation of extending and unlinking and one for the >>> link_existiing.html view. In the section_linkage view, you can now >>> see that extending or linking backwards in time is now supported. >>> Also, Ithere is an additional link below the section link for >>> unlinking the section. >>> >>> The two confirmation views are self-explanatory. I understand that we >>> don't want the user to regret hitting a link that takes an important >>> action to change the data. In the case of the link_existing view, >>> correct me if I'm wrong, but since the user clicks a radio button >>> followed by clicking the Link button, I assumed that I wouldn't need a >>> confirmation step for that action, like when a user chooses a teacher >>> or student to add to a section and then clicks Add. >>> >>> I also attached a screenshot of the error message the shows when the >>> user tries to click Link without choosing a section target. With this >>> view, as with all the other views, any suggestions for changing >>> something are welcome. >>> >>> Also, please review the code changes before finishing for the week so >>> that I can make any adjustments between now and next Monday's meeting. >>> >>> Thanks, >>> Alan >>> >>> >>> >>> On Mon, Apr 11, 2011 at 9:11 AM, Tom Hoffman <tom.hoffman@xxxxxxxxx> wrote: >>>> On Mon, Apr 11, 2011 at 3:43 AM, Justas <justas@xxxxxx> wrote: >>>>> Hey, >>>>> >>>>> On 04/11/2011 08:16 AM, Alan Elkner wrote: >>>> >>>>>> I added CSS classes to schooltool.css that make the table follow the >>>>>> guidelines laid out on page 27 of the Ubuntu style guide. That >>>>>> includes the dotted line as border-bottom of table cells. I chose >>>>>> 220px as column width rather than 140px because it seemed too narrow, >>>>>> and people will rarely use more than four terms. >>>>> >>>>> Umm.. why 220px? Just couldn't figure out the reasoning behind this >>>>> number. >>>>> >>>>> Page 26 also says "Table width: 100%. Table should use the whole width of >>>>> the content area." This of course works pretty well when your content area >>>>> is 544px (as in the guidelines), and may look quirky when it is whole page >>>>> width, like we have now. So no objections, just curious. >>>> >>>> Given that there could be an arbitrarily large number of terms, making >>>> the page arbitrarily wide seems better than allowing the columns to >>>> become arbitrarily narrow. >>>> >>>>> As a compromise, maybe we could have "link existing section" in all >>>>> unlinked terms, and "extend to term" only in terms after the last linked >>>>> one? Get the best of both worlds - soft hint what user should do + >>>>> possibility to fix mistakes. >>>> >>>> That would probably be best. Also, maybe an "unlink" option too? >>>> >>>>> I'd also like if ExtendTermView had a confirmation button. In my >>>>> experience, links that create content without confirmation bite users hard >>>>> (in javascripty implementations you usually have to use at least two mouse >>>>> clicks, see assigning a developer to a bug in Launchpad). >>>> >>>> Yes, we probably should. >>>> >>>> --Tom >>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~schooltool-developers >>>> Post to : schooltool-developers@xxxxxxxxxxxxxxxxxxx >>>> Unsubscribe : https://launchpad.net/~schooltool-developers >>>> More help : https://help.launchpad.net/ListHelp >>>> >>> >> >
Attachment:
extend_term.png
Description: PNG image
Attachment:
link_existing.png
Description: PNG image
Attachment:
unlink.png
Description: PNG image
Attachment:
section_linkage.png
Description: PNG image
| Thread Previous • Date Previous • Date Next • Thread Next |
