ubuntu-touch-coreapps-reviewers team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into lp:ubuntu-terminal-app.

Commit message:
* Fixed standard ANSI blue color in the Ubuntu color scheme (previously it was red)
* Use the official Ubuntu palette (based on the UbuntuColors singleton of UITK)

Requested reviews:
  Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
  Bug #1452691 in Ubuntu Terminal App: "Standard ANSI blue color is red."
  https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1452691

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme/+merge/285170

* Fixed standard ANSI blue color in the Ubuntu color scheme (previously it was red)
* Use the official Ubuntu palette (based on the UbuntuColors singleton of UITK)

Comparison: (left: new color scheme - right: old color scheme) 
https://imgur.com/FqnT8GG

QUESTIONS:
* The background is much darker now. That's the background color used in SuruDark (UbuntuColors.jet).
  Let me know if we want to use a lighter color (e.g. the UbuntuColors.inkstone - currently used as Color0Intense)

* Should intense color be a bit lighter too?
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into lp:ubuntu-terminal-app.

=== modified file 'src/plugin/qmltermwidget/lib/color-schemes/Ubuntu.colorscheme'
--- src/plugin/qmltermwidget/lib/color-schemes/Ubuntu.colorscheme	2014-11-16 22:38:02 +0000
+++ src/plugin/qmltermwidget/lib/color-schemes/Ubuntu.colorscheme	2016-02-05 10:33:19 +0000
@@ -1,103 +1,138 @@
+# UbuntuColors are taken from:
+# http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/staging/view/head:/src/Ubuntu/Components/1.3/UbuntuColors.qml
+
+# Colors that are not included in the official palette have been generated with:
+# http://www.color-hex.com/
+
+# Same as Color0 (Black)
 [Background]
 Bold=false
-Color=51,51,51
+Color=17,17,17
 Transparency=false
 
+# Same as Color0Intense (Black)
 [BackgroundIntense]
 Bold=true
-Color=51,51,51
+Color=59,59,59
 Transparency=false
 
+# Black: UbuntuColors.jet
 [Color0]
 Bold=false
-Color=63,63,63
+Color=17,17,17
 Transparency=false
 
+# BlackIntense: UbuntuColors.inkstone
 [Color0Intense]
 Bold=true
-Color=112,144,128
+Color=59,59,59
 Transparency=false
 
+# Red: UbuntuColors.red
 [Color1]
 Bold=false
-Color=112,80,80
+Color=237,49,70
 Transparency=false
 
+# RedIntense: a tint of UbuntuColors.red (#f05a6a)
+# http://www.color-hex.com/color/ed3146
 [Color1Intense]
 Bold=true
-Color=220,163,163
+Color=240,90,106
 Transparency=false
 
+#`Green: UbuntuColors.green
 [Color2]
 Bold=false
-Color=96,180,138
+Color=62,179,79
 Transparency=false
 
+#`GreenIntense: a tint of UbuntuColors.green (#64c272)
+# http://www.color-hex.com/color/3eb34f
 [Color2Intense]
 Bold=true
-Color=114,213,163
+Color=100,194,114
 Transparency=false
 
+# Yellow: analogous of UbuntuColors.orange (#e9b920)
+# http://www.color-hex.com/color/e95420
 [Color3]
 Bold=false
-Color=223,175,143
+Color=223,185,32
 Transparency=false
 
+# YellowIntense: a tint of the yellow above (#edc74c)
+# http://www.color-hex.com/color/e9b920
 [Color3Intense]
 Bold=true
-Color=240,223,175
+Color=237,199,76
 Transparency=false
 
+# Blue: UbuntuColors.blue
 [Color4]
 Bold=false
-Color=220,62,16
+Color=25,182,238
 Transparency=false
 
+# BlueIntense: a tint of UbuntuColors.blue (#46c4f1)
+# http://www.color-hex.com/color/19b6ee
 [Color4Intense]
 Bold=true
-Color=221,72,20
+Color=70,196,241
 Transparency=false
 
+# Magenta: complementary of UbuntuColors.green (#b33ea2)
+# http://www.color-hex.com/color/3eb34f
 [Color5]
 Bold=false
-Color=220,140,195
+Color=179,62,162
 Transparency=false
 
+# MagentaIntense: a tint of the magenta above (#c264b4)
+# http://www.color-hex.com/color/b33ea2
 [Color5Intense]
 Bold=true
-Color=236,147,211
+Color=194,100,180
 Transparency=false
 
+# Cyan: complementary of UbuntuColors.red (#31edd8)
+# http://www.color-hex.com/color/ed3146
 [Color6]
 Bold=false
-Color=140,208,211
+Color=49,237,216
 Transparency=false
 
+# CyanIntense: a tint of the cyan above (#5af0df)
+# http://www.color-hex.com/color/31edd8
 [Color6Intense]
 Bold=true
-Color=147,224,227
+Color=90,240,223
 Transparency=false
 
+# White: UbuntuColors.silk
 [Color7]
 Bold=false
-Color=220,220,204
+Color=193,193,193
 Transparency=false
 
+# WhiteIntense: 255 - UbuntuColors.jet
 [Color7Intense]
 Bold=true
-Color=255,255,255
+Color=236,236,236
 Transparency=false
 
+# Same as Color7 (White)
 [Foreground]
 Bold=false
-Color=220,220,204
+Color=193,193,193
 Transparency=false
 
+# Same as Color7Intense (White)
 [ForegroundIntense]
 Bold=true
-Color=220,220,204
+Color=236,236,236
 Transparency=false
 
 [General]
-Description=Dark Pastels
+Description=Ubuntu
 Opacity=1