ubuntu-touch-coreapps team mailing list archive

[Renato Filho <renato.filho@xxxxxxxxxxxxx>]

Hi David,

Sorry because of the delay  to reply, I am very busy with others bugs :D

I took a look on kunal, code and looks good  I think I found the problem on
EDS plugin, this is faling to get the correct default collection and
probably kunal has more the one EDs source on his machine, the inital fix
for that can be found in this branch[1]. Besides that I have noticed that
kunal is creating a lot of CalendarModels inside of the application and you
should avoid that, instead of doing that try to share the object with the
others componnents, this will save some memory and will speed up the hole
application.


About this piece of code:

        eventModel.saveItem(event);
        eventModel.itemAdded();


You should not call " eventModel.itemAdded();" explicitly this should be
done by  " eventModel.saveItem(event);"  if this is not working let me know.


Thanks
Renato


[1] lp:~renatofilho/qtorganizer5-eds/fix-default-source


On Tue, Sep 24, 2013 at 7:24 AM, David Planella
<david.planella@xxxxxxxxxx>wrote:

> Hi Renato,
>
> Have you been able to look at Kunal's code and give him any feedback on
> why the EDS manager is crashing?
>
> It would help us a lot in getting the New Event view and the Qt Organizer
> migration in the calendar moving.
>
> Thanks!
>
> Cheers,
> David.
>
>
>
> On Sat, Sep 21, 2013 at 4:39 AM, kunal parmar <pkunal.parmar@xxxxxxxxx>wrote:
>
>> Hi Renato,
>>
>> Sorry for late reply,
>>
>> I don't think invalid event object is problem here. I was already
>> following same example and some other test code from Qt.
>>
>> https://qt.gitorious.org/qt/qtpim/source/a03045ec1f378dc32d779b5526ca1fda7e66d770:tests/auto/organizer/qmlorganizer/testcases/tst_organizeritem.qml
>>
>> And my code is working fine with "memory" manager, I am facing problem
>> only with  "eds" manager.
>> So I suspect problem lies somewhere else.
>>
>> My code is here, may be you can quick review and provide some feedback.
>>
>> http://bazaar.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/QtOrganizer/view/head:/NewEvent.qml
>>
>> ~Kunal
>>
>>
>>
>>
>> On Wed, Sep 18, 2013 at 10:03 PM, Renato Filho <
>> renato.filho@xxxxxxxxxxxxx> wrote:
>>
>>> Hi Kunal,
>>>
>>> This error is caused because you are trying to save a event without all
>>> the necessary information (incomplete event).
>>>
>>> Take a look on qtpim example code:
>>> https://qt.gitorious.org/qt/qtpim/source/e6c2773a5c6c341bb18311dfa65cbebf97bf5e42:examples/organizer/qmlorganizerlistview
>>>
>>>
>>>
>>>
>>> On Wed, Sep 18, 2013 at 1:08 AM, kunal parmar <pkunal.parmar@xxxxxxxxx>wrote:
>>>
>>>> Hi Renato,
>>>>
>>>> I tried latest branch from
>>>> https://code.launchpad.net/~ubuntu-sdk-team/qtorganizer5-eds/trunk
>>>>
>>>> Now crash is resolved, but event is not getting saved.
>>>> I am getting "Fail to create items: Cannot create calendar object:
>>>> Invalid object".
>>>>
>>>>
>>>> static void QOrganizerEDSEngine::itemsAsyncStart(FetchRequestData*)
>>>>
>>>> virtual bool
>>>> QOrganizerEDSEngine::startRequest(QtOrganizer::QOrganizerAbstractRequest*)
>>>>
>>>> void
>>>> QOrganizerEDSEngine::saveItemsAsync(QtOrganizer::QOrganizerItemSaveRequest*)
>>>>
>>>>
>>>> static void QOrganizerEDSEngine::saveItemsAsyncConnected(GObject*,
>>>> GAsyncResult*, SaveRequestData*)
>>>>
>>>> static ECalComponent* QOrganizerEDSEngine::parseEventItem(ECalClient*,
>>>> const QtOrganizer::QOrganizerItem&)
>>>>
>>>> static void QOrganizerEDSEngine::saveItemsAsyncCreated(GObject*,
>>>> GAsyncResult*, SaveRequestData*)
>>>>
>>>> Fail to create items: Cannot create calendar object: Invalid object
>>>>
>>>> virtual QOrganizerEDSEngine::~QOrganizerEDSEngine()
>>>>
>>>>
>>>>
>>>>
>>>> On Mon, Sep 16, 2013 at 7:51 AM, <pkunal.parmar@xxxxxxxxx> wrote:
>>>>
>>>>> Hi,
>>>>> Thanks, so fix will be available with upgrade or I need to download
>>>>> branch?
>>>>>
>>>>> ~Kunal
>>>>>
>>>>>  Sent from my BlackBerry 10 smartphone.
>>>>>   *From: *Renato Filho
>>>>> *Sent: *Sunday, September 15, 2013 6:54 AM
>>>>> *To: *kunal parmar
>>>>> *Cc: *David Planella; Timo Jyrinki; ubuntu-touch-coreapps
>>>>> *Subject: *Re: Issues with Qt Organizer in the Calendar app
>>>>>
>>>>> Hi kunal parmar,
>>>>>
>>>>> This was fixed on bzr trunk on rev. 12.
>>>>>
>>>>> Thanks
>>>>> Renato
>>>>>
>>>>> On Sat, Sep 14, 2013 at 2:46 AM, kunal parmar <pkunal.parmar@xxxxxxxxx>
>>>>> wrote:
>>>>> > HI Renato,
>>>>> >
>>>>> > Currently I am trying to use QtOrganizer with EDS pluig0in.
>>>>> >
>>>>> > But facing issue with adding event to QtOrgainzer. When I save event
>>>>> > to qtpim, seems like EDS plugin is crashing.
>>>>> >
>>>>> > I tried to debug, is seems like , following call is failing.
>>>>> >
>>>>> > e_cal_client_connect(collectionEngineId->m_esource,
>>>>> > E_CAL_CLIENT_SOURCE_TYPE_EVENTS,
>>>>> > data->cancellable(),
>>>>> > (GAsyncReadyCallback)
>>>>> > QOrganizerEDSEngine::saveItemsAsyncConnected,
>>>>> > data);
>>>>> >
>>>>> > Can you let me know if I am missing anything.
>>>>> >
>>>>> > Folliwing is log from EDS
>>>>> > "
>>>>> >
>>>>> > virtual QtOrganizer::QOrganizerManagerEngine*
>>>>> > QOrganizerEDSFactory::engine(const QMap<QString, QString>&,
>>>>> > QtOrganizer::QOrganizerManager::Error*) eds
>>>>> >
>>>>> > QOrganizerEDSEngine::QOrganizerEDSEngine()
>>>>> >
>>>>> > 2 Collection loaded
>>>>> >
>>>>> > QObject::connect: Cannot connect QQuickShaderEffectSource:: to
>>>>> > ShapeItem_QML_43::onImagePropertiesChanged()
>>>>> >
>>>>> > QObject::connect: Cannot connect QQuickShaderEffectSource:: to
>>>>> > ShapeItem_QML_43::onImagePropertiesChanged()
>>>>> >
>>>>> > QObject::connect: Cannot connect QQuickShaderEffectSource:: to
>>>>> > ShapeItem_QML_43::onImagePropertiesChanged()
>>>>> >
>>>>> > virtual bool
>>>>> QOrganizerEDSEngine::startRequest(QtOrganizer::QOrganizerAbstractRequest*)
>>>>> >
>>>>> > virtual bool
>>>>> QOrganizerEDSEngine::startRequest(QtOrganizer::QOrganizerAbstractRequest*)
>>>>> >
>>>>> > void
>>>>> QOrganizerEDSEngine::itemsAsync(QtOrganizer::QOrganizerItemFetchRequest*)
>>>>> >
>>>>> > static void QOrganizerEDSEngine::itemsAsyncStart(FetchRequestData*)
>>>>> >
>>>>> > virtual void
>>>>> QOrganizerEDSEngine::requestDestroyed(QtOrganizer::QOrganizerAbstractRequest*)
>>>>> >
>>>>> > static void QOrganizerEDSEngine::itemsAsyncConnected(GObject*,
>>>>> > GAsyncResult*, FetchRequestData*)
>>>>> >
>>>>> > static void QOrganizerEDSEngine::itemsAsyncListed(GObject*,
>>>>> > GAsyncResult*, FetchRequestData*)
>>>>> >
>>>>> > Query size: 0
>>>>> >
>>>>> > static void QOrganizerEDSEngine::itemsAsyncStart(FetchRequestData*)
>>>>> >
>>>>> > static void QOrganizerEDSEngine::itemsAsyncConnected(GObject*,
>>>>> > GAsyncResult*, FetchRequestData*)
>>>>> >
>>>>> > static void QOrganizerEDSEngine::itemsAsyncListed(GObject*,
>>>>> > GAsyncResult*, FetchRequestData*)
>>>>> >
>>>>> > Query size: 0
>>>>> >
>>>>> > static void QOrganizerEDSEngine::itemsAsyncStart(FetchRequestData*)
>>>>> >
>>>>> > virtual bool
>>>>> QOrganizerEDSEngine::startRequest(QtOrganizer::QOrganizerAbstractRequest*)
>>>>> >
>>>>> > void
>>>>> QOrganizerEDSEngine::saveItemsAsync(QtOrganizer::QOrganizerItemSaveRequest*)
>>>>> >
>>>>> >
>>>>> > The program has unexpectedly finished.
>>>>> > "
>>>>> >
>>>>> >
>>>>> > On Fri, Aug 16, 2013 at 12:14 PM, Renato Filho
>>>>> > <renato.filho@xxxxxxxxxxxxx> wrote:
>>>>> >> Hi guys,
>>>>> >>
>>>>> >> As we discussed today during the calendar app meeting, we decided
>>>>> to use the
>>>>> >> new EDS backend instead of keep trying the unmaintained jsondb.
>>>>> >>
>>>>> >> To you guys that want to start to play with that. I have created a
>>>>> package
>>>>> >> on sdk ppa[1] (The official package will be in the image soon). The
>>>>> plugin
>>>>> >> is in a very early stage, but you will be able to
>>>>> create/remove/edit basic
>>>>> >> events. (Recurrence is not fully working).
>>>>> >>
>>>>> >> To try this, make sure that you have the last qtpim5 version
>>>>> >> (5.0~git20130723-0ubuntu1) then you can try the qtpim example
>>>>> code[2], you
>>>>> >> will need to replace the edit the qmlorganizerlistview.qml file on
>>>>> line 151
>>>>> >> and replace from " manager: "memory" " to " manager: "eds" ".
>>>>> >>
>>>>> >> Good luck
>>>>> >>
>>>>> >> OBS: This plugin is only one week old, you will probably find some
>>>>> bugs.
>>>>> >> Please fell free to report then on the lp project page[3]
>>>>> >>
>>>>> >> [1]
>>>>> >>
>>>>> https://launchpad.net/~ubuntu-sdk-team/+archive/ppa/+sourcepub/3428324/+listing-archive-extra
>>>>> >> [2]
>>>>> >>
>>>>> http://qt.gitorious.org/qt/qtpim/trees/master/examples/organizer/qmlorganizerlistview
>>>>> >> [3] https://launchpad.net/qtorganizer5-eds
>>>>> >>
>>>>> >>
>>>>> >>
>>>>> >> On Thu, Aug 15, 2013 at 10:00 AM, kunal parmar <
>>>>> pkunal.parmar@xxxxxxxxx>
>>>>> >> wrote:
>>>>> >>>
>>>>> >>> Hi David,
>>>>> >>>
>>>>> >>> I insalled JasonDB plugin, this "qtdeclarative5-jsondb-plugin"
>>>>> jasonDb
>>>>> >>> plugin seems like JasonDB QML binding, its not Jason Backend
>>>>> plaugin
>>>>> >>> for QtOrganizer.
>>>>> >>>
>>>>> >>> I am still getting only memory as valid backend for QtOrganizer.
>>>>> >>>
>>>>> >>> ~Kunal
>>>>> >>>
>>>>> >>> On Thu, Aug 15, 2013 at 5:37 PM, <pkunal.parmar@xxxxxxxxx> wrote:
>>>>> >>> > Hi,
>>>>> >>> >
>>>>> >>> > I thought it will install with qtpim plugin. I did not install
>>>>> >>> > explicitly. I
>>>>> >>> > will install and let you know.
>>>>> >>> >
>>>>> >>> > Thanks,
>>>>> >>> > Kunal
>>>>> >>> >
>>>>> >>> > Sent from my BlackBerry 10 smartphone.
>>>>> >>> > From: David Planella
>>>>> >>> > Sent: Thursday, August 15, 2013 5:21 PM
>>>>> >>> > To: kunal parmar
>>>>> >>> > Cc: Timo Jyrinki; ubuntu-touch-coreapps; Renato Filho
>>>>> >>> > Subject: Re: Issues with Qt Organizer in the Calendar app
>>>>> >>> >
>>>>> >>> > Hi Kunal,
>>>>> >>> >
>>>>> >>> > I'm seeing the qtsjondb plugin here [1]. Could you check if
>>>>> you've got
>>>>> >>> > the
>>>>> >>> > qtdeclarative5-jsondb-plugin package installed?
>>>>> >>> >
>>>>> >>> > Cheers,
>>>>> >>> > David.
>>>>> >>> >
>>>>> >>> > [1]
>>>>> >>> >
>>>>> >>> >
>>>>> https://launchpad.net/~ubuntu-sdk-team/+archive/ppa/+packages?field.name_filter=qtjsondb&field.status_filter=published&field.series_filter=raring
>>>>> >>> >
>>>>> >>> >
>>>>> >>> > On Thu, Aug 15, 2013 at 4:38 AM, kunal parmar <
>>>>> pkunal.parmar@xxxxxxxxx>
>>>>> >>> > wrote:
>>>>> >>> >>
>>>>> >>> >> Hi David,
>>>>> >>> >>
>>>>> >>> >> I forgot to mention,
>>>>> >>> >>
>>>>> >>> >> I am still not seeing Jason DB plugin for QtPim, Am I missing
>>>>> something
>>>>> >>> >> ?
>>>>> >>> >>
>>>>> >>> >> kunal@kunal-sammy:/usr/lib/i386-linux-gnu/qt5/plugins/organizer$
>>>>> ll
>>>>> >>> >> total 128
>>>>> >>> >> drwxr-xr-x 2 root root 4096 Aug 15 10:57 ./
>>>>> >>> >> drwxr-xr-x 24 root root 4096 Aug 3 13:58 ../
>>>>> >>> >> -rw-r--r-- 1 root root 121152 Aug 13 17:50
>>>>> libqtorganizer_memory.so
>>>>> >>> >> kunal@kunal-sammy:/usr/lib/i386-linux-gnu/qt5/plugins/organizer$
>>>>> pwd
>>>>> >>> >> /usr/lib/i386-linux-gnu/qt5/plugins/organizer
>>>>> >>> >> kunal@kunal-sammy
>>>>> :/usr/lib/i386-linux-gnu/qt5/plugins/organizer$
>>>>> >>> >>
>>>>> >>> >> ~Kunal
>>>>> >>> >>
>>>>> >>> >>
>>>>> >>> >>
>>>>> >>> >> On Thu, Aug 15, 2013 at 11:31 AM, kunal parmar
>>>>> >>> >> <pkunal.parmar@xxxxxxxxx>
>>>>> >>> >> wrote:
>>>>> >>> >>>
>>>>> >>> >>> Hi David,
>>>>> >>> >>>
>>>>> >>> >>> I updated my installation and installed latest qtpim.
>>>>> >>> >>>
>>>>> >>> >>> it looks like working fine. my initial test seems to work.
>>>>> >>> >>>
>>>>> >>> >>> I will continue porting current calendar to use QtPim and will
>>>>> let you
>>>>> >>> >>> know if face any other issue.
>>>>> >>> >>>
>>>>> >>> >>> However, when I currently try to print Organizer model item,
>>>>> using
>>>>> >>> >>> following code
>>>>> >>> >>>
>>>>> >>> >>> for( var prop in event) {
>>>>> >>> >>>
>>>>> >>> >>> print(prop +":"+ event[prop]);
>>>>> >>> >>>
>>>>> >>> >>> }
>>>>> >>> >>>
>>>>> >>> >>>
>>>>> >>> >>> It give me following with output, seems like it require some
>>>>> more
>>>>> >>> >>> changes.
>>>>> >>> >>>
>>>>> >>> >>>
>>>>> >>> >>> QMetaProperty::read: Unable to handle unregistered datatype
>>>>> >>> >>> 'QDeclarativeOrganizerItemPriority::Priority' for property
>>>>> >>> >>> 'QtOrganizer::QDeclarativeOrganizerEvent::priority'
>>>>> >>> >>> priority:undefined
>>>>> >>> >>> QMetaProperty::read: Unable to handle unregistered datatype
>>>>> >>> >>> 'QDeclarativeOrganizerItemType::ItemType' for property
>>>>> >>> >>> 'QtOrganizer::QDeclarativeOrganizerEvent::itemType'
>>>>> >>> >>> itemType:undefined
>>>>> >>> >>>
>>>>> >>> >>>
>>>>> >>> >>> Kunal
>>>>> >>> >>>
>>>>> >>> >>>
>>>>> >>> >>>
>>>>> >>> >>>
>>>>> >>> >>> On Tue, Aug 13, 2013 at 10:12 PM, David Planella
>>>>> >>> >>> <david.planella@xxxxxxxxxx> wrote:
>>>>> >>> >>>>
>>>>> >>> >>>> Al 10/08/13 08:17, En/na kunal parmar ha escrit:
>>>>> >>> >>>> > Hi David,
>>>>> >>> >>>> >
>>>>> >>> >>>> > Sure I will create a sample application and submit bugs for
>>>>> problem
>>>>> >>> >>>> > which I am facing.
>>>>> >>> >>>> >
>>>>> >>> >>>> > BTW did you check if 13.04 version has required QtPim patch
>>>>> ?
>>>>> >>> >>>>
>>>>> >>> >>>> Hi Kunal,
>>>>> >>> >>>>
>>>>> >>> >>>> Timo and Renato tell me that the qtpim version has now been
>>>>> upgraded
>>>>> >>> >>>> in
>>>>> >>> >>>> 13.04 and it should contain Renato's upstream patches.
>>>>> >>> >>>>
>>>>> >>> >>>> Could you try to upgrade it and report back if it works for
>>>>> you?
>>>>> >>> >>>>
>>>>> >>> >>>> Thanks!
>>>>> >>> >>>>
>>>>> >>> >>>> Cheers,
>>>>> >>> >>>> David.
>>>>> >>> >>>>
>>>>> >>> >>>> > Thanks,
>>>>> >>> >>>> > Kunal
>>>>> >>> >>>> >
>>>>> >>> >>>> > On Fri, Aug 9, 2013 at 7:23 PM, Timo Jyrinki
>>>>> >>> >>>> > <timo.jyrinki@xxxxxxxxxxxxx> wrote:
>>>>> >>> >>>> >> Hi,
>>>>> >>> >>>> >>
>>>>> >>> >>>> >> Sure, I'm happy to include patches especially after
>>>>> they've been
>>>>> >>> >>>> >> submitted upstream
>>>>> >>> >>>> >> (https://codereview.qt-project.org/#q,project:qt/qtpim,n,z- if
>>>>> >>> >>>> >> already merged by then, I can then just pull the latest
>>>>> snapshot).
>>>>> >>> >>>> >>
>>>>> >>> >>>> >> We've currently a version of qtpim that includes all
>>>>> commits until
>>>>> >>> >>>> >> the
>>>>> >>> >>>> >> 'Added support to preferredDetails on QML Contact.'.
>>>>> >>> >>>> >>
>>>>> >>> >>>> >> -Timo
>>>>> >>> >>>> >>
>>>>> >>> >>>> >>
>>>>> >>> >>>> >> On Fri, Aug 9, 2013 at 10:41 AM, David Planella
>>>>> >>> >>>> >> <david.planella@xxxxxxxxxx> wrote:
>>>>> >>> >>>> >>> Hi all,
>>>>> >>> >>>> >>>
>>>>> >>> >>>> >>> In yesterday's Calendar IRC meeting [1] Kunal raised some
>>>>> issues
>>>>> >>> >>>> >>> that
>>>>> >>> >>>> >>> he's encountered while porting the calendar event storage
>>>>> code to
>>>>> >>> >>>> >>> use
>>>>> >>> >>>> >>> the Qt Organizer API.
>>>>> >>> >>>> >>>
>>>>> >>> >>>> >>> Kunal, do you think you could create a simple program to
>>>>> >>> >>>> >>> reproduce
>>>>> >>> >>>> >>> the
>>>>> >>> >>>> >>> bugs you're experimenting in the app, submit them
>>>>> upstream and
>>>>> >>> >>>> >>> report
>>>>> >>> >>>> >>> back with the bug URLS?
>>>>> >>> >>>> >>>
>>>>> >>> >>>> >>> Renato, Timo, once that's done, could you help us fixing
>>>>> the
>>>>> >>> >>>> >>> issues
>>>>> >>> >>>> >>> and
>>>>> >>> >>>> >>> package a working qtpim version that can be used for the
>>>>> Calendar
>>>>> >>> >>>> >>> app?
>>>>> >>> >>>> >>>
>>>>> >>> >>>> >>> Thanks!
>>>>> >>> >>>> >>>
>>>>> >>> >>>> >>> Cheers,
>>>>> >>> >>>> >>> David.
>>>>> >>> >>>> >>>
>>>>> >>> >>>> >>> [1]
>>>>> >>> >>>> >>>
>>>>> >>> >>>> >>>
>>>>> >>> >>>> >>>
>>>>> http://ubottu.com/meetingology/logs/ubuntu-touch-meeting/2013/ubuntu-touch-meeting.2013-08-08-14.01.html
>>>>> >>> >>>>
>>>>> >>> >>>
>>>>> >>> >>
>>>>> >>> >
>>>>> >>> >
>>>>> >>
>>>>> >>
>>>>>
>>>>
>>>>
>>>
>>
>