← Back to team overview

kicad-developers team mailing list archive

Re: Locale fix in KiCAD is not working (breaks my build)


On 03/15/2013 02:07 PM, Dick Hollenbeck wrote:
> On 03/15/2013 01:46 PM, Miguel Angel Ajo Pelayo wrote:
>> On 15/03/2013, at 19:32, Dick Hollenbeck <dick@xxxxxxxxxxx> wrote:
>>> On 03/15/2013 11:39 AM, Miguel Angel Ajo Pelayo wrote:
>>>> Ok, committed in 4008, cleanups included. 
>>>> Finally I used the LOCALE_IO implementation, because converting in
>>>> some situations didn't work, and my time was exhausting for today…
>>>> I think there are some locale manipulators in std:: c++ that would
>>>> let us do those conversions without switching system locale, but we will have to try.
>>> We don't have to try.  We could wait until there is a problem.
>> I feel like planting bombs around ;)
>>> If or when there is a problem, I would fight to protect the interfaces
>>> we have become dependent on, one of which is OUTPUTFORMATTER::Print().
>>> You shouldn't try to re-implement this without my help.
>> In vsnprintf (used in OUTPUTFORMATTER::vprint) is affected by locale too, right?,
>> You mean that on locale changes we should protect those call?
> Yes, so that means OUTPUTFORMATTER::Print() is not thread safe
> currently, 

Rather, probably it is thread safe, but the locale change is not
thread specific to my knowledge.

Follow ups