kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #25712
Re: Git transition
-
To:
Chris Pavlina <pavlina.chris@xxxxxxxxx>, Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
From:
Maciej Sumiński <maciej.suminski@xxxxxxx>
-
Date:
Wed, 10 Aug 2016 21:28:26 +0200
-
Authentication-results:
spf=pass (sender IP is 188.184.36.50) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
Cc:
KiCad Developers List <kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
In-reply-to:
<CAJjCH9r5gjhbAqU5V_9OJ2Zk3gMZMzrj=3BikVG1wFzMKsjU8g@mail.gmail.com>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
On 08/10/2016 04:49 PM, Chris Pavlina wrote:
[snip]
> Any particular reason for having (fixes lp:########) in the first
> line? Typically the first line of the commit message is kept very
> short and limited to things one might need when quickly browsing a
> log. The usual convention in git is to write something like this at
> the bottom of the message:
>
> Fixes: lp:########
>
> It's very easy to search for those if you want, using git log --grep:
>
> git log --grep="^Fixes: lp:12345678"
Currently the webhook accepts a few formats: "fix(es)?[
]+(lp:|#)?([0-9]+)", but it can be easily changed. I would not mind
extending it to catch the mentioned phrase. It also accepts the formula
anywhere in the commit message, not only the first line, so it is up to
Wayne to set the rules.
Regards,
Orson
Attachment:
signature.asc
Description: OpenPGP digital signature
References
