← Back to team overview

kicad-developers team mailing list archive

Re: Zone filling & display speed improvements

 

On 5 December 2017 at 06:02, Tomasz Wlostowski
<tomasz.wlostowski@xxxxxxx> wrote:
> On 05/12/17 08:55, jp charras wrote:
>> Le 05/12/2017 à 01:41, Tomasz Wlostowski a écrit :
>>> Hi guys,
>>>
>>> Now it should work fine - the filling algorithm was not thread safe and
>>> apparently wxProgressDialog can't be invoked from non-main thread.
>>>
>>> Check out the updated branch.
>>>
>>> Thanks!
>>> Tom
>>>
>>
>> Hi Tom,
>>
>> It works fine for me.
>> And on my 4 cores computer, the speedup is really impressive!
>>
>> Thanks.
>>
>
> Hi guys,
>
> Thanks for testing, I just merged it to the master.

There is still the left-over method RemoveInsulatedCopperIslands()
declaration that is otherwise never defined or used; so this needs to
be done:

------------------------------------------------------------------------------------
--- a/pcbnew/class_zone.h
+++ b/pcbnew/class_zone.h
@@ -151,13 +151,6 @@ public:

    int GetClearance( BOARD_CONNECTED_ITEM* aItem = NULL ) const override;

-    /**
-     * Function RemoveInsulatedCopperIslands
-     * Remove insulated copper islands found in m_FilledPolysList.
-     * @param aPcb = the board to analyze
-     */
-    void RemoveInsulatedCopperIslands( BOARD* aPcb );
-
    /**
     * Function IsOnCopperLayer
     * @return true if this zone is on a copper layer, false if on a
technical layer
----------------------------------------------------------------------------------------

(This will prevent the scripting from compiling as Swig is generating
stub-code from the header but then complains while linking that it
does not exist).

-h

>
> Tom
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


References