← Back to team overview

launchpad-dev team mailing list archive

Re: Putting on-call reviewer in channel topic?

 

On Thu, Sep 10, 2009 at 4:03 AM, William Grant<me@xxxxxxxxxxxxxxxxxx> wrote:
> On Thu, 2009-09-10 at 10:21 +0200, Henning Eggers wrote:
>> Am 10.09.2009 03:17, Brad Crittenden schrieb:
>> >
>> > On Sep 9, 2009, at 19:03 , Karl Fogel wrote:
>> >
>> >> Christian Robottom Reis <kiko@xxxxxxxxxxxxx> writes:
>> >>> at any rate, the fact that
>> >>> you don't know about #launchpad-reviews may point to us not marketing
>> >>> that channel properly?
>> >>
>> >> The situation is worse than that: I knew about the channel and then
>> >> *forgot* about it, because nothing ever happened to pull me into it.
>> >
>> > Right, but you would've found out the first time you wanted to submit a
>> > branch for review.
>>
>> And if you are new to the process, you would be reading
>> https://dev.launchpad.net/PatchSubmission which mentions the channel in
>> step #1.
>>
>> >
>> >> My guess is most people who use IRC know how to ignore the chatter
>> >> around them, when they're focused on a particular conversation.  Do we
>> >> have evidence or experience to suggest that doing reviews in the dev
>> >> channel was a real problem?  If we don't, I'd really like to try merging
>> >> it back into #launchpad-dev and seeing what happens.
>> >
>> > I'm -1 on combining the two channels.
>>
>> -1 from me, too, for all the reasons mentioned here.
>
> -1 from me as well, for the usual reasons.
>

While I'm really not in favor of moving #launchpad-reviews to
#launchpad-dev either, I wonder if there isn't a way to keep our
current work flow and also get some of what Karl wants.

We're thinking of reviews as the official channel for our work, the
OCR-queue, etc.  I know that often reviews happen outside of whoever
is on call.  Frequently, I get asked to take a look at something, or I
ask one of my bugs colleagues when they aren't on call, or ask someone
to look at a UI, and so on.  Maybe for this sort of thing it would be
okay to ping someone in #launchpad-dev, ask for the review, and then
say "let's continue the review in #launchpad-reviews" -- or some
similar pattern.

It's just a suggestion and I don't think needs a hard rule, but it
would allow #launchpad-reviews to work largely as it does now, which
does indeed work very well for us, but also could allow for some of
the serendipitous connections that Karl is hoping for.

Cheers,
deryck


-- 
Deryck Hodge
https://launchpad.net/~deryck
http://www.devurandom.org/



Follow ups

References