← Back to team overview

openerp-community team mailing list archive

Re: Coding Guidlines - long lines

 

I prefer 79 as well.

I also agree with the pep8 idea of not using backslashes, but "using
Python's implied
 line continuation inside parentheses, brackets and braces."

OpenERP example:

        'date_order': fields.date(
            'Date', required=True, readonly=True, select=True,
            states={
                'draft': [('readonly', False)],
                'sent': [('readonly', False)]
            }),

Instead of the long line found in the actual openobject-addons code

l


On Sat, Nov 23, 2013 at 4:27 PM, Oscar Alca <oszckar@xxxxxxxxx> wrote:

> http://hg.python.org/peps/rev/fb24c80e9afb#l1.95
>
>
> On Fri, Nov 22, 2013 at 10:38 AM, Sebastien Beau <
> sebastien.beau@xxxxxxxxxxxxxxx> wrote:
>
>> Hi
>> I also support 79.
>> When I start on python I was thinking that 79 was not enough. But now
>> every time I read the code of an OpenERP Module that respect pep8. I really
>> enjoy it, it's really more readable, so let's stay on 79.
>>
>>
>> 2013/11/22 Stefan <stefan@xxxxxxxx>
>>
>>> On 11/22/2013 05:15 PM, Oscar Alca wrote:
>>>
>>>> Hello Raphael I also understand the question why the question was
>>>> rised, also, I do not think that PEP8 Is ambiguous, it says maximum of 100
>>>> with effective 99 for code mantained by a team, so, we, as a team, are
>>>> allowed to a maximum of 100.
>>>>
>>>
>>> Hi Oscar,
>>>
>>> it does not say 'code maintained by a team', it says "[maintained] by a
>>> team that can reach agreement on this issue". And as a member of that team,
>>> I prefer 79 like Alexandre for now.
>>>
>>> Cheers,
>>> Stefan
>>>
>>> --
>>> Therp - Maatwerk in open ontwikkeling
>>>
>>> Stefan Rijnhart - Ontwerp en implementatie
>>>
>>> mail: stefan@xxxxxxxx
>>> tel: +31 (0) 614478606
>>> web: http://therp.nl
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~openerp-community
>>> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~openerp-community
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~openerp-community
>> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~openerp-community
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
>
> --
>
>
>
>
> Ing. Oscar Alcalá Rivera
> *312-107-1704* · oszckar@xxxxxxxxx <ozckar@xxxxxxxxx>
>
> Paseo de Bugambilias 251 · Villa de alvarez, Colima, CP 28978
> Tlf: *3123111122 <3123111122>*
>
> *Open Source Enthusiast*
>      [image: twitter] <http://twitter.com/oscarolar> [image: linkedIn]<http://www.linkedin.com/pub/oscar-alcal%C3%A1/3b/a79/922>
>    [image: Google+] <http://plus.google.com/107659954580035981067/posts>
>
> [image: eco] No me imprimas si no es necesario. Protejamos el medio
> ambiente
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp
>
>

Follow ups

References