maria-developers team mailing list archive

[Kristian Nielsen <knielsen@xxxxxxxxxxxxxxx>]

Otto Kekäläinen <otto@xxxxxxxxx> writes:

> 2014-03-14 12:59 GMT+02:00 Kristian Nielsen <knielsen@xxxxxxxxxxxxxxx>:
>
>> Create a new hook ("Add webhook" button), Make it post to this url:
>>
>>
>> https://buildbot.askmonty.org/buildbot/change_hook/github?project=MariaDB

> These are in place, and I just pushed. Let's see what happens in the
> following hours.

Hm, it doesn't seem to work :-(

No "pending builds" show up on the buildbot pages, and I see this error in the
buildbot log:

2014-03-17 21:01:29+0200 [HTTPChannel,167,127.0.0.1] Attempting to load module buildbot.status.web.hooks.github
2014-03-17 21:01:29+0200 [HTTPChannel,167,127.0.0.1] in process_change
2014-03-17 21:01:29+0200 [HTTPChannel,167,127.0.0.1] ERROR:root:Encountered an exception:
2014-03-17 21:01:29+0200 [HTTPChannel,167,127.0.0.1] ERROR:root:Traceback (most recent call last):
2014-03-17 21:01:29+0200 [HTTPChannel,167,127.0.0.1] ERROR:root:File "/usr/lib/python2.7/dist-packages/buildbot/status/web/hooks/github.py", line 100, in getChanges
2014-03-17 21:01:29+0200 [HTTPChannel,167,127.0.0.1]     changes = process_change(payload, user, repo, repo_url, project)
2014-03-17 21:01:29+0200 [HTTPChannel,167,127.0.0.1] ERROR:root:File "/usr/lib/python2.7/dist-packages/buildbot/status/web/hooks/github.py", line 139, in process_change
2014-03-17 21:01:29+0200 [HTTPChannel,167,127.0.0.1]     when =  convertTime( commit['timestamp'])
2014-03-17 21:01:29+0200 [HTTPChannel,167,127.0.0.1] ERROR:root:File "/usr/lib/python2.7/dist-packages/buildbot/status/web/hooks/github.py", line 63, in convertTime
2014-03-17 21:01:29+0200 [HTTPChannel,167,127.0.0.1]     result.groups()
2014-03-17 21:01:29+0200 [HTTPChannel,167,127.0.0.1] ERROR:root:AttributeError: 'NoneType' object has no attribute 'groups'
2014-03-17 21:01:29+0200 [HTTPChannel,167,127.0.0.1] Unhandled Error
        Traceback (most recent call last):
          File "/usr/lib/python2.7/dist-packages/twisted/web/http.py", line 1349, in dataReceived
            finishCallback(data[contentLength:])
          File "/usr/lib/python2.7/dist-packages/twisted/web/http.py", line 1563, in _finishRequestBody
            self.allContentReceived()
          File "/usr/lib/python2.7/dist-packages/twisted/web/http.py", line 1618, in allContentReceived
            req.requestReceived(command, path, version)
          File "/usr/lib/python2.7/dist-packages/twisted/web/http.py", line 773, in requestReceived
            self.process()
        --- <exception caught here> ---
          File "/usr/lib/python2.7/dist-packages/twisted/web/server.py", line 132, in process
            self.render(resrc)
          File "/usr/lib/python2.7/dist-packages/twisted/web/server.py", line 167, in render
            body = resrc.render(self)
          File "/usr/lib/python2.7/dist-packages/twisted/web/resource.py", line 216, in render
            return m(request)
          File "/usr/lib/python2.7/dist-packages/buildbot/status/web/change_hook.py", line 62, in render_POST
            changes, src = self.getChanges( request )
          File "/usr/lib/python2.7/dist-packages/buildbot/status/web/change_hook.py", line 108, in getChanges
            changes, src = tempModule.getChanges(request,self.dialects[dialect])
        exceptions.TypeError: 'NoneType' object is not iterable

I tried pulling your repo into mine and pushing that, and then I get the same
error.

A quick google shows this as the likely culprit:

    http://trac.buildbot.net/ticket/2054

Looks like something changed recently with the data format somewhere, which
buildbot does not like. Indeed, in the last delivery to the buildbot hook from
github, it has this:

   "timestamp": "2014-03-13T11:08:10Z",

Whereas my successful pushes had this:

   "timestamp": "2014-03-18T09:25:12+01:00",

Note how the time zone is specified differently, the "Z" is not parsable by
our current Buildbot, apparently :-(

Maybe there is a way to avoid that kind of timestamp when committing, as a
workaround? (I am not sure whether this is something that git does, or
something that github does, though the fact that it works for my commits and
not for others suggests git).

Otherwise, I suppose we need to ask Daniel to upgrade buildbot to something
that fixes this issue. There is a patch in the Buildbot track ticket, but it
might be some work to upgrade...


> The current error at
> http://buildbot.askmonty.org/buildbot/builders/debpkg-trusty/builds/3/steps/compile/logs/stdio
> will go away of you add to the build command '-us -uc' at the end as I
> wrote earlier today:
>
>    git-buildpackage --git-pristine-tar --git-notify=false -us -uc

Yes, should be fixed.

> For
> http://buildbot.askmonty.org/buildbot/builders/debpkg-sid/builds/0/steps/compile/logs/stdio

Should be fixed also (it's just an old build).

But we'll need to sort out the problem with the github integration...

 - Kristian.