← Back to team overview

openerp-community team mailing list archive

  1. openerp-community team
  2. Mailing list archive
  3. Message #04093

Re: Coding Guidlines - long lines

  Thread Previous • Date Previous • • Thread Next 
hello,

[background]i start this discussion, because i want to submit my code,
but fulfil even 79 rule, our merge request are still open, but this is a
other problem[/backgound]

in my opinion the "i prefer" discussion has not outcome. I guess we need
a good example where 79 char rule is implemented and the module is
complex. I look in the new magento-connector and there 7500 times
breaking this rule over all modules you need to use.

So if the big contributors like Camp2Camp will use this rule strict, the
rest of the community will follow, i think.

If the big one ignoring it and you say to the small one (like us) use
it, you will loss us.

[ironic]i name my variable "absrl" instad of
account_bank_statement_reconcile_line, this saves me a lot of chars, but
the code will be worst[/ironic]

On 25.11.2013 15:41, Jose Antonio Morales wrote:
> Hello.
> 
> I think the same way that Oscar does.
> 
> When I saw the PEP8 updates almost cry of happiness, because 79 char is
> too short when you fully follow the pep8 rules, you can see the account
> code and then tell me if 79 char is enough.
> 
> The answer is simple is not enough because you would have to cut the
> code lines to follow the PEP8 and this makes your code to be ugly.
> 
> I follow the PEP8 rules even in the fields definition and I tell them
> again 79 is not enough.
> 
> If you want follow the PEP8 fully 79 is not enough if you want follow
> the PEP8 in some lines(bad way) you can use 79 char.
> 
> Use this command pep8 --show-source --show-pep8 for know how many rules
> you are broken.
> 
> 
> On Mon, Nov 25, 2013 at 1:42 AM, Mario Arias <the.clone.master@xxxxxxxxx
> <mailto:the.clone.master@xxxxxxxxx>> wrote:
> 
>     +1  for 79 chars...
> 
>     I am on the road working on my laptop most of the time...
> 
>     Regards,
>     -Mario
> 
> 
>     On Sun, Nov 24, 2013 at 2:48 PM, Franco Tampieri
>     <franco.tampieri@xxxxxxxxxxx <mailto:franco.tampieri@xxxxxxxxxxx>>
>     wrote:
> 
>         I like python pep8 rule, code i much readable on small diplay,
>         so I agree at 100% to the community approach.
> 
>         Regards
> 
>         Franco
> 
>         Franco Tampieri
>         System Engineer
>         >_
>         abstract.it <http://abstract.it> - +39 06 9294 6938
>         Registro Imprese di Napoli 788429 / Cap. Soc. 10.000 Euro I.V.
>         Avvertenze Legali – D. Lgs. 196/03 Tutela dei dati personali. Le
>         informazioni contenute in questo messaggio
>         e in ogni eventuale allegato sono riservate e ne è vietata ogni
>         forma di diffusione. Se avete ricevuto questa comunicazione per
>         errore, Vi preghiamo di informare immediatamente il mittente del
>         messaggio e di eliminare l'e-mail.
> 
> 
> 
>         2013/11/24 Leonardo Pistone <leonardo.pistone@xxxxxxxxxxxxxx
>         <mailto:leonardo.pistone@xxxxxxxxxxxxxx>>
> 
>             I prefer 79 as well.
> 
>             I also agree with the pep8 idea of not using backslashes,
>             but "using Python's implied
>              line continuation inside parentheses, brackets and braces."
> 
>             OpenERP example:
> 
>                     'date_order': fields.date(
>                         'Date', required=True, readonly=True, select=True,
>                         states={
>                             'draft': [('readonly', False)],
>                             'sent': [('readonly', False)]
>                         }),
> 
>             Instead of the long line found in the actual
>             openobject-addons code
> 
>             l
> 
> 
>             On Sat, Nov 23, 2013 at 4:27 PM, Oscar Alca
>             <oszckar@xxxxxxxxx <mailto:oszckar@xxxxxxxxx>> wrote:
> 
>                 http://hg.python.org/peps/rev/fb24c80e9afb#l1.95
> 
> 
>                 On Fri, Nov 22, 2013 at 10:38 AM, Sebastien Beau
>                 <sebastien.beau@xxxxxxxxxxxxxxx
>                 <mailto:sebastien.beau@xxxxxxxxxxxxxxx>> wrote:
> 
>                     Hi
>                     I also support 79.
>                     When I start on python I was thinking that 79 was
>                     not enough. But now every time I read the code of an
>                     OpenERP Module that respect pep8. I really enjoy it,
>                     it's really more readable, so let's stay on 79.
> 
> 
>                     2013/11/22 Stefan <stefan@xxxxxxxx
>                     <mailto:stefan@xxxxxxxx>>
> 
>                         On 11/22/2013 05:15 PM, Oscar Alca wrote:
> 
>                             Hello Raphael I also understand the question
>                             why the question was rised, also, I do not
>                             think that PEP8 Is ambiguous, it says
>                             maximum of 100 with effective 99 for code
>                             mantained by a team, so, we, as a team, are
>                             allowed to a maximum of 100.
> 
> 
>                         Hi Oscar,
> 
>                         it does not say 'code maintained by a team', it
>                         says "[maintained] by a team that can reach
>                         agreement on this issue". And as a member of
>                         that team, I prefer 79 like Alexandre for now.
> 
>                         Cheers,
>                         Stefan
> 
>                         -- 
>                         Therp - Maatwerk in open ontwikkeling
> 
>                         Stefan Rijnhart - Ontwerp en implementatie
> 
>                         mail: stefan@xxxxxxxx <mailto:stefan@xxxxxxxx>
>                         tel: +31 (0) 614478606
>                         <tel:%2B31%20%280%29%20614478606>
>                         web: http://therp.nl
> 
> 
> 
>                         _________________________________________________
>                         Mailing list:
>                         https://launchpad.net/~__openerp-community
>                         <https://launchpad.net/~openerp-community>
>                         Post to     :
>                         openerp-community@lists.__launchpad.net
>                         <mailto:openerp-community@xxxxxxxxxxxxxxxxxxx>
>                         Unsubscribe :
>                         https://launchpad.net/~__openerp-community
>                         <https://launchpad.net/~openerp-community>
>                         More help   :
>                         https://help.launchpad.net/__ListHelp
>                         <https://help.launchpad.net/ListHelp>
> 
> 
> 
>                     _______________________________________________
>                     Mailing list: https://launchpad.net/~openerp-community
>                     Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>                     <mailto:openerp-community@xxxxxxxxxxxxxxxxxxx>
>                     Unsubscribe : https://launchpad.net/~openerp-community
>                     More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
>                 -- 
> 
> 
>                   	 
>                 	
> 
>                 Ing. Oscar Alcalá Rivera
>                 *312-107-1704 <tel:312-107-1704>* · oszckar@xxxxxxxxx
>                 <mailto:ozckar@xxxxxxxxx>
> 
>                 Paseo de Bugambilias 251 · Villa de alvarez, Colima, CP
>                 28978
>                 Tlf: *3123111122 <tel:3123111122>*
> 
>                 /Open Source Enthusiast/
> 
>                    twitter <http://twitter.com/oscarolar> linkedIn
>                 <http://www.linkedin.com/pub/oscar-alcal%C3%A1/3b/a79/922>   Google+
>                 <http://plus.google.com/107659954580035981067/posts>  
> 
>                 eco No me imprimas si no es necesario. Protejamos el
>                 medio ambiente
> 
> 
>                 _______________________________________________
>                 Mailing list: https://launchpad.net/~openerp-community
>                 Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>                 <mailto:openerp-community@xxxxxxxxxxxxxxxxxxx>
>                 Unsubscribe : https://launchpad.net/~openerp-community
>                 More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
>             _______________________________________________
>             Mailing list: https://launchpad.net/~openerp-community
>             Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>             <mailto:openerp-community@xxxxxxxxxxxxxxxxxxx>
>             Unsubscribe : https://launchpad.net/~openerp-community
>             More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
>         _______________________________________________
>         Mailing list: https://launchpad.net/~openerp-community
>         Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>         <mailto:openerp-community@xxxxxxxxxxxxxxxxxxx>
>         Unsubscribe : https://launchpad.net/~openerp-community
>         More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~openerp-community
>     Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>     <mailto:openerp-community@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~openerp-community
>     More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> -- 
> Jose Morales
> Senior Developer
> Site: http://vauxoo.com <http://vauxoo.com/>
> Email: j <mailto:rsilvam@xxxxxxxxxx>ose@xxxxxxxxxx <mailto:ose@xxxxxxxxxx>
> Twitter: @joseamoralesp
> Skype: joseamoralesp
> LPUser: https://launchpad.net/~josemoralesp
> Phone: +58 (426) 310 69 65
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp
> 

-- 
Dipl.-Comp.-Math. Markus Schneider
Softwareentwickler

initOS GmbH & Co. KG
An der Eisenbahn 1
21224 Rosengarten

Mobil:   +49 (0)172 2303699
Phone:   +49 (0)4105 5615613
Fax:     +49 (0)4105 5615610

Email:   markus.schneider@xxxxxxxxxx
Web:     http://www.initos.com

Geschäftsführung:
Dipl. Wirt.-Inf. Frederik Kramer & Dipl.-Ing. (FH) Torsten Francke
Haftende Gesellschafterin: initOS Verwaltungs GmbH

Sitz der Gesellschaft: Rosengarten – Klecken
Amtsgericht Tostedt, HRA 201840
USt-IdNr: DE 275698169
Steuer-Nr: 15/205/21402

Follow ups

References

  Thread Previous • Date Previous • • Thread Next