launchpad-dev team mailing list archive

[Karl Fogel <karl.fogel@xxxxxxxxxxxxx>]

Christian Robottom Reis <kiko@xxxxxxxxxxxxx> writes:
> On Thu, Sep 10, 2009 at 03:03:56PM +0100, Tom Berger wrote:
>> When we came up with on call reviews and the reviews channel, there
>> were two things very different from now:
>> 
>> 1. Only about a third of the developers on the regular team were reviewers.
>> 2. We wanted a channel that's focused on code, rather than operation.
>
> I still think the "focused" part of the latter holds. OCR is precious,
> and reviewer time is precious, and having the channel quiet unless
> reviews are happening is a good way of preserving that.
>
> I don't think it's a problem if people want to do occasional reviews on
> -dev; I just think it's best if the OCR works on a separate channel.

(Thanks for the historical context, Tom.)  I suggest an experiment:

Can a few reviewers try just doing their thing in #launchpad-dev when
they're on call?  (Follow up to say if you'll try it.)

We just need data, really.  If using the same channel really causes
distraction on either side, then a separate channel is needed.  But if
not, then we should merge them -- at least until there *is* a problem
someday.

As Tom pointed out, we don't have any operational stuff in the public
channel anymore.  And the #launchpad-dev channel is not at all
overburdened right now -- sometimes it's busy, sometimes it's quiet, but
I don't normally see it so busy that having a review going on in there
would cause problems, either for the review or for the rest of the
channel.

Also, looking over the #launchpad-reviews traffic today, and comparing
it with the #launchpad-dev traffic, it doesn't seem to me that it would
have been a problem for them both to be the same channel.  That's just
one day, but still...

-Karl