← Back to team overview

lubuntu-desktop team mailing list archive

Re: Call for review: PCManFM is almost ready for a new release.


Le Sunday 19 June 2011 à 06:27 -0700, Jonathan Marsden a écrit :
> On 06/18/2011 10:07 PM, PCMan wrote:
> >> Add LINGUAS, reference doc files and libfm-pref-apps.desktop launcher:
> > We do not translate desktop files directly. Neither do we commit the
> > translated desktop files.
Most likely a quick and dirty patch on Ubuntu packaging for the .desktop
part :)

> >> Ensure correct icon is used in panel.
> > A better fix is to set the icon-name property for the window in
> > GtkBuilder glade file instead.
> OK.  I am more of a command-line person than a GUI programmer, the GTK
> UI stuff is relatively new to me.  As I recall, I fixed the bug in the
> way Julien suggested it be fixed.  There were several similar issues
> with icon names not being set in various LXDE-related tools.  I fixed
> them all in a similar way to this, and those patches were accepted by
> Julien into the Ubuntu packaging.  I can redo this in glade if that is
> the correct approach.  I'm not really sure I understand the benefit of
> moving one line from code into a glade file, though.
Yes, it makes sense to keep all the UI magic in the glade/ui file. I
wasn't aware that it can be done like this.

> >> Disable deprecated gio code by default.
> > This looks fine, but will this affect distros with older versions of glib?
> Possibly, I'm not sure.  However, are new releases of pcmanfm intended
> for backporting to those older distros?  I'm not sure this is an issue
> in practice for a new pcmanfm/libfm release, unless current development
> releases of major distros (Fedora, SuSE, Debian, ...) are still using
> older glib versions.
As far as I know, this flag just makes the build fail when a deprecated
code is detected. It doesn't affect the code itself or the behavior of
the program.

Julien Lavergne

Follow ups