kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxxxx>]

On 8/29/2011 4:58 PM, Dick Hollenbeck wrote:
> 
>> Dick,
>>
>> I ran into a problem on Windows this morning with a segfault when creating the
>> language menu.  I added KiBitmap() where the images get added to the menu item
>> and it seems to have fixed the problem on CvPcb.  It's still in the process of
>> building so I'm not sure if there are other issues in any of the other apps.
>> I'm working on it and I'll keep you posted.
> 
> I think the problem was the
> 
>     const BITMAP_REF&  m_Lang_Icon;
> 
> 
> which I think should now be:
> 
> 
>     BITMAP_DEF m_Lang_Icon;
> 
> 
> This keeps from making those bitmaps on any platform except Windows and only if
> your
> USE_IMAGES_IN_MENUS toggle is on.
> 
> 
> Also, we'd eventually have needed the attached tweak to SetBitmaps() in macros.h.
> 
> Please consider the attached patch, and try it on Windows please.
> 
> Feel free to commit it or say I can.
> 
> 
> Thanks,
> 
> Dick

I fixed this by changing BITMAP_DEF to wxBitmap and used KiBitmap() in the
static structures which solved the problem.  If your solution is the correct
way to go, I can make the change.

Wayne

> 
> 
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp