kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #23407
Re: 3D refactor
Den 25/02/2016 15.08 skrev "Wayne Stambaugh" <stambaughw@xxxxxxxxx>:
>
> I found KISYS3DMOD was set to the path where KiCad was installed but I
> don't think I set it. Does the windows installer set the KISYSMOD and
> KISYS3DMOD environment variables for all users? I deleted the
> KISYS3DMOD environment variable and Pcbnew did not crash. However, I
> still got the warning dialog about the missing model file when Pcbnew
> was launched. @Cirilo, would you please change this so that the missing
> 3D model warning dialog is displayed when the 3D viewer is launched
> rather than when Pcbnew is launched. I'm guessing this will annoy users.
>
> What is most concerning is that when I ran kicad from gdb, it did not
> crash so there is something at play here that makes me uncomfortable. I
> ran it from the mingw64 version of gdb as well as the mingw64 version of
> QT Creator and it ran fine in both cases. The bzr version on the
> installer says r6528 even though the version string says no-bzr.
Without looking too much into it, I guss if this is ok on the normal
nightlies, which I think is the case, then I suspect the cmakelists to be
outdated in the 3d_initial_merge branch.
> On 2/25/2016 4:46 AM, Nick Østergaard wrote:
> > Hi Wayne
> >
> > It does not crash for me. Does this also happen if the KISYS3DMOD env
> > var is not set on your system?
> >
> > The plugins seems to be loaded correctly because I can see the 3D
> > models in the preview.
> >
> > Also, the build is a debug build, you should be able to run the
> > pcbnew.exe you installed form the the gdb in msys2, if you can
> > reproduce the issue when running form msys2.
> >
> > 2016-02-24 21:33 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
> >> The installed windows version is crashing for me. When I launch Pcbnew
> >> from KiCad I get a warning dialog about KISYS3DMOD
> >> (3d-refactor-win64-install-1.png). When I dismiss this dialog I get a
> >> windows system warning dialog (3d-refactor-win64-install-2.png. When I
> >> dismiss the windows system warning dialog, pcbnew crashes taking kicad
> >> with it. I didn't look but is it possible that Pcbnew is not finding
> >> the 3d plugin library. Cirilo, would you please verify the windows
> >> library load and install paths?
> >>
> >> On 2/24/2016 1:12 PM, Nick Østergaard wrote:
> >>> See http://downloads.kicad-pcb.org/windows/testing/3d_initial_merge/
> >>>
> >>> I have not tested it recently, it might have some issue, please test
it.
> >>>
> >>> 2016-02-24 18:51 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
> >>>> Thanks Bernhard,
> >>>>
> >>>> Before I committed the 3D refactor, I was going to ask our package
devs
> >>>> to take a look at it due to the new 3D model plugins. I would like
to
> >>>> get this correct before I commit it. What's the status on windows.
> >>>> I've built and installed from source and that works find but I'm
> >>>> guessing our installers will need to be changed to accommodate this.
> >>>> Once we have the install issues sorted out, I'll commit it.
> >>>>
> >>>> Cheers,
> >>>>
> >>>> Wayne
> >>>>
> >>>> On 2/24/2016 12:26 PM, Bernhard Stegmaier wrote:
> >>>>> Hi,
> >>>>>
> >>>>> I just tried on OS X and plugin handling doesn’t seem to be OK.
> >>>>> At least, “make install” does directly (try to) install them to
> >>>>> “/Applications/…” which is completely wrong (and also maybe the
case why
> >>>>> my built binary doesn’t find them?). Also, the path itself under
> >>>>> SharedSupport I guess isn’t right.
> >>>>>
> >>>>> It also install this here
> >>>>> bstegmaier$ ls -al /Applications/kicad.app/Contents/Macos/
> >>>>> total 464
> >>>>> drwxr-xr-x 4 bstegmaier admin 136 24 Feb 18:17 .
> >>>>> drwxr-xr-x 3 bstegmaier admin 102 24 Feb 18:17 ..
> >>>>> -rwxr-xr-x 1 bstegmaier admin 231560 24 Feb 18:17
> >>>>> libkicad_3dsg..0.0.dylib
> >>>>> lrwxr-xr-x 1 bstegmaier admin 24 24 Feb 18:17
libkicad_3dsg.dylib
> >>>>> -> libkicad_3dsg..0.0.dylib
> >>>>> which doesn’t look right, what is it good for?
> >>>>>
> >>>>> If you like, I can have a look and try to fix this.
> >>>>>
> >>>>>
> >>>>> Regards,
> >>>>> Bernhard
> >>>>>
> >>>>>> On 23.02.2016, at 22:21, Cirilo Bernardo <cirilo.bernardo@xxxxxxxxx
> >>>>>> <mailto:cirilo.bernardo@xxxxxxxxx>> wrote:
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> On Tue, Feb 23, 2016 at 7:37 PM, jp charras <jp.charras@xxxxxxxxxx
> >>>>>> <mailto:jp.charras@xxxxxxxxxx>> wrote:
> >>>>>>
> >>>>>> Le 23/02/2016 08:56, Cirilo Bernardo a écrit :
> >>>>>> > On Tue, Feb 23, 2016 at 3:00 AM, Wayne Stambaugh <
stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
> >>>>>> > wrote:
> >>>>>> >
> >>>>>> >> Cirilo,
> >>>>>> >>
> >>>>>> >> I have one last change request that I missed in my previous
review.
> >>>>>> >> Please change your debugging output method. Windows apps
have no
> >>>>>> >> concept of stdout even when run from the command line.
wxLogTrace is
> >>>>>> >> the preferred method for debugging output. It solves two
problems. The
> >>>>>> >> debugging strings are redirected to the correct output on
all supported
> >>>>>> >> platforms and the debugging output is turned off by
default. Turning on
> >>>>>> >> the debugging output is as simple as:
> >>>>>> >>
> >>>>>> >> export WXTRACE="SOME_DEBUGGING_OUTPUT_TO_ENABLE"
> >>>>>> >>
> >>>>>> >> The is handy so I don't have to sift through everyone's
debugging output
> >>>>>> >> to find what I'm looking for. You just need to pick a
unique string not
> >>>>>> >> used by any other kicad wxLogTrace calls to enable tracing
of your
> >>>>>> >> debugging output.
> >>>>>> >>
> >>>>>> >>
> >>>>>> > The 3d_initial_merge branch has been updated to use
wxLogTrace;
> >>>>>> > it has also been synchronized to the main branch r6527. The
latest
> >>>>>> > revision for the 3d_initial_merge branch is r6527. The
branch builds
> >>>>>> > successfully and I have tested the previewer with various
VRML1/2 and
> >>>>>> > X3D models.
> >>>>>> >
> >>>>>> > - Cirilo
> >>>>>>
> >>>>>> Thanks, Cirilo.
> >>>>>> Very good work.
> >>>>>>
> >>>>>> At least on Windows, 3d_plugin_manager.cpp is missing the line:
> >>>>>> #include <wx/filename.h>
> >>>>>>
> >>>>>> Without this include, it does not compile.
> >>>>>>
> >>>>>> --
> >>>>>> Jean-Pierre CHARRAS
> >>>>>>
> >>>>>> _______________________________________________
> >>>>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>>>> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>>>> More help : https://help.launchpad.net/ListHelp
> >>>>>>
> >>>>>>
> >>>>>> Thanks Jean-Pierre,
> >>>>>>
> >>>>>> I have added the header and checked that it builds on Windows
(W7-64
> >>>>>> bit).
> >>>>>>
> >>>>>> - Cirilo
> >>>>>>
> >>>>>> _______________________________________________
> >>>>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>>>> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>>>> More help : https://help.launchpad.net/ListHelp
> >>>>>
> >>>>>
> >>>>>
> >>>>> _______________________________________________
> >>>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>>> More help : https://help.launchpad.net/ListHelp
> >>>>>
> >>>>
> >>>> _______________________________________________
> >>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>> More help : https://help.launchpad.net/ListHelp
References
-
3D refactor
From: Cirilo Bernardo, 2016-02-22
-
Re: 3D refactor
From: Wayne Stambaugh, 2016-02-22
-
Re: 3D refactor
From: Cirilo Bernardo, 2016-02-23
-
Re: 3D refactor
From: jp charras, 2016-02-23
-
Re: 3D refactor
From: Cirilo Bernardo, 2016-02-23
-
Re: 3D refactor
From: Bernhard Stegmaier, 2016-02-24
-
Re: 3D refactor
From: Wayne Stambaugh, 2016-02-24
-
Re: 3D refactor
From: Nick Østergaard, 2016-02-24
-
Re: 3D refactor
From: Wayne Stambaugh, 2016-02-24
-
Re: 3D refactor
From: Nick Østergaard, 2016-02-25
-
Re: 3D refactor
From: Wayne Stambaugh, 2016-02-25