← Back to team overview

openerp-expert-framework team mailing list archive

Re: Making our way out from the bloated extra-addons repository

 

On Mon, Nov 5, 2012 at 1:09 PM, Raphael Valyi <rvalyi@xxxxxxxxx> wrote:

> Yes no problem Joêl, we could rename that branch.
> May be Something like payment-order would be appropriate here (BTW the
> original module creators just documented the Tryton equivalent modules
> http://code.google.com/p/tryton/wiki/PaymentOrder )
>
> I should still analyse if all these extracted modules fit under some
> really common topic. As a reminder, the extraction criteria was "extract
> the extra-addons closest to account_payment_order without leaving isolated
> often needed module alone". This was the first criteria for rescuing from
> the extra-addons without adding extra-complexity it doesn't necessarily
> means these extra-addons are homogeneous enough today.
>
> In any case, I think we can now safely use the 2 basic "topological"
> operations that will allow us to manage these branches from now on:
>
>    - we can split further using the same kind of script when we will need
>    it
>    - we can "group" branches together I think. In that case, Let's just
>    rebased them on a common ancestor (my branch ancestor is extra-addons
>    already) and do a merge. The history of each leg is still the history of
>    the original module branch.
>
>
> So I was focused on the extraction, now, we can focus on the management of
> the extracted branches. If you at CampToCamp want to create some Launchpad
> financial project to regroup these branches to make them easier to discover
> and administer, please do it, we will move the branches under that new
> umbrella.
>
> Also, something important we should do now:
> educate the previous extra-addons users and committers about the new
> branches to avoid the maintenance to happen in the extra-addons instead of
> using these new branches.
>
> What can we do for that?
> 1) send summary emails to the communities, I'll do it
>
> 2) remove the extracted modules from the extra-addons? That's a bit brutal
> for the beginners following these branches may be. Something we could do
> instead could be add some kind of raise an automatic exception when the
> code of the module is read, something like "that modules moved to branch X,
> please download and use branch X or delete that code line alternatively if
> you want to ignore that warning"
>
> What do you think? What would be the best way to deprecate these modules
> in some insisting but easy to fix way?
>

IMO just dont allow more commits after split, if split extra-addons happens
and we get other branches it is better dont allow more commits and
notificate to community and change the branch details explaining the new
road to follow and put the links there, so if anyone push changes migrate
changes will happens every time and nobody must|can maintain that.

Regards,


> Regards,
>
>
> --
> Raphaël Valyi
> Founder and consultant
> http://twitter.com/rvalyi <http://twitter.com/#!/rvalyi>
> +55 21 2516 2954
> www.akretion.com
>
>
>
> On Mon, Nov 5, 2012 at 3:54 PM, Joël Grand-Guillaume <
> joel.grandguillaume@xxxxxxxxxxxxxx> wrote:
>
>> Hello Raphaël,
>>
>>
>> Thanks for the work ! I only have one remark about the name of the
>> branch. Why financial-extra-addons ? I just though those days about naming
>> the branch, and if we make branch name that are too generic, we'll just
>> land in the same situation in a few months/year. Note, you already know
>> that ;)
>>
>> For example, we're thinking about splitting our branches into smaller,
>> more community oriented branches. We already have ~30 financial modules,
>> and we don't want to commit them all in that branch.. I started with
>> logistic topic and made for example those branches:
>>
>> *
>>
>>    - stock-logistic-warehouse
>>    - stock-logistic-barcode
>>
>>
>>    - stock-logistic-tracking
>>    - stock-logistic-flows
>>
>> *
>>
>> Would you agree to find another more precise name ? I don't actually know
>> which one cause I don't know what's exactly inside..
>>
>> Though ?
>>
>>
>> Cheers,
>>
>>
>> Joël
>>
>>
>> Le 5 nov. 2012 à 18:02, Raphael Valyi <rvalyi@xxxxxxxxx> a écrit :
>>
>> Hello
>>
>> after spending really too much time at doing, that, here is the
>> extraction of the 6.1 financial extra-addons:
>>
>> https://code.launchpad.net/~openerp-commiter/openobject-addons/financial-extra-addons
>>
>> To extract it, I used the brute force script I described previously (not
>> using any bzr broken tooling but only bzr revert and brute force file copy)
>> The command is:
>>
>> /home/rvalyi/Downloads/bzr-super-replay2
>> /opt/openerp/branch/ref/61/extra-trunk 3000 -m account_payment_extension
>> purchase_payment sale_payment pxgo_bank_statement_analytic
>> pxgo_cash_statement pxgo_bank_statement_running_balance paydays
>> nan_account_bank_statement --hide-translation --hide_merge
>>
>> while the bzr-super-replay2 script is https://gist.github.com/4018293
>>
>> So you can download the script and run it too.
>> Make sure you have the mixlib-shellout gem installed with the following
>> command:
>> gem install mixlib-shellout --no-ri --no-rdoc
>>
>> The extracted financial addons are:
>>
>> account_payment_extension
>> paydays
>> pxgo_bank_statement_analytic
>> pxgo_cash_statement
>> nan_account_bank_statement
>> purchase_payment
>> pxgo_bank_statement_running_balance
>> sale_payment
>>
>> The extraction took something like 5 minutes on a laptop with Intel(R)
>> Core(TM) i5-2450M CPU @ 2.50GHz CPU's (the extraction is mono process
>> anyway).
>>
>> If you want to extract a particular set of extra-addons, you can also ask
>> me to do it for you.
>>
>> Next we should create a proper Launchpad project and groups to manage
>> these extracted branches.
>>
>> Does the branch looks good enough for you?
>> NB: the last commit is a merge that was pending in the extra-addons, but
>> I kind of assumed from here the development has to happen in the new
>> extracted branch from now on.
>>
>> Thoughts?
>>
>>
>> Enjoy!
>>
>>
>> --
>> Raphaël Valyi
>> Founder and consultant
>> http://twitter.com/rvalyi <http://twitter.com/#!/rvalyi>
>> +55 21 2516 2954
>> www.akretion.com
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~openerp-expert-framework
>> Post to     : openerp-expert-framework@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~openerp-expert-framework
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>>      --
>>
>>
>> *Joël Grand-Guillaume** *
>> *Division Manager*
>> *Business Solutions*
>> *
>> *
>> *Camptocamp SA*
>> PSE A, CH-1015 Lausanne
>>
>> http://openerp.camptocamp.com/
>>
>>
>> Phone: +41 21 619 10 28
>> Office: +41 21 619 10 10
>> Fax: +41 21 619 10 00
>> Email: joel.grandguillaume@xxxxxxxxxxxxxx
>>
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-expert-framework
> Post to     : openerp-expert-framework@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-expert-framework
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 
Cristian Salamea
@ovnicraft

Follow ups

References